Skip to content

Commit 4434f5e

Browse files
committed
review comments
1 parent 8d1f6cb commit 4434f5e

File tree

1 file changed

+16
-20
lines changed

1 file changed

+16
-20
lines changed

tools/sift.go

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -233,11 +233,10 @@ var ListSiftInvestigations = mcpgrafana.MustTool(
233233

234234
// FindErrorPatternLogsParams defines the parameters for running an ErrorPatternLogs check
235235
type FindErrorPatternLogsParams struct {
236-
Name string `json:"name" jsonschema:"required,description=The name of the investigation"`
237-
Labels map[string]string `json:"labels" jsonschema:"required,description=Labels to scope the analysis"`
238-
Start time.Time `json:"start,omitempty" jsonschema:"description=Start time for the investigation. Defaults to 30 minutes ago if not specified."`
239-
End time.Time `json:"end,omitempty" jsonschema:"description=End time for the investigation. Defaults to now if not specified."`
240-
QueryURL string `json:"queryUrl,omitempty" jsonschema:"description=Optional query URL for the investigation"`
236+
Name string `json:"name" jsonschema:"required,description=The name of the investigation"`
237+
Labels map[string]string `json:"labels" jsonschema:"required,description=Labels to scope the analysis"`
238+
Start time.Time `json:"start,omitempty" jsonschema:"description=Start time for the investigation. Defaults to 30 minutes ago if not specified."`
239+
End time.Time `json:"end,omitempty" jsonschema:"description=End time for the investigation. Defaults to now if not specified."`
241240
}
242241

243242
// findErrorPatternLogs creates an investigation with ErrorPatternLogs check, waits for it to complete, and returns the analysis
@@ -249,11 +248,10 @@ func findErrorPatternLogs(ctx context.Context, args FindErrorPatternLogsParams)
249248

250249
// Create the investigation request with ErrorPatternLogs check
251250
requestData := investigationRequest{
252-
Labels: args.Labels,
253-
Start: args.Start,
254-
End: args.End,
255-
QueryURL: args.QueryURL,
256-
Checks: []string{string(checkTypeErrorPatternLogs)},
251+
Labels: args.Labels,
252+
Start: args.Start,
253+
End: args.End,
254+
Checks: []string{string(checkTypeErrorPatternLogs)},
257255
}
258256

259257
investigation := &Investigation{
@@ -299,11 +297,10 @@ var FindErrorPatternLogs = mcpgrafana.MustTool(
299297

300298
// FindSlowRequestsParams defines the parameters for running an SlowRequests check
301299
type FindSlowRequestsParams struct {
302-
Name string `json:"name" jsonschema:"required,description=The name of the investigation"`
303-
Labels map[string]string `json:"labels" jsonschema:"required,description=Labels to scope the analysis"`
304-
Start time.Time `json:"start,omitempty" jsonschema:"description=Start time for the investigation. Defaults to 30 minutes ago if not specified."`
305-
End time.Time `json:"end,omitempty" jsonschema:"description=End time for the investigation. Defaults to now if not specified."`
306-
QueryURL string `json:"queryUrl,omitempty" jsonschema:"description=Optional query URL for the investigation"`
300+
Name string `json:"name" jsonschema:"required,description=The name of the investigation"`
301+
Labels map[string]string `json:"labels" jsonschema:"required,description=Labels to scope the analysis"`
302+
Start time.Time `json:"start,omitempty" jsonschema:"description=Start time for the investigation. Defaults to 30 minutes ago if not specified."`
303+
End time.Time `json:"end,omitempty" jsonschema:"description=End time for the investigation. Defaults to now if not specified."`
307304
}
308305

309306
// findSlowRequests creates an investigation with SlowRequests check, waits for it to complete, and returns the analysis
@@ -315,11 +312,10 @@ func findSlowRequests(ctx context.Context, args FindSlowRequestsParams) (*analys
315312

316313
// Create the investigation request with SlowRequests check
317314
requestData := investigationRequest{
318-
Labels: args.Labels,
319-
Start: args.Start,
320-
End: args.End,
321-
QueryURL: args.QueryURL,
322-
Checks: []string{string(checkTypeSlowRequests)},
315+
Labels: args.Labels,
316+
Start: args.Start,
317+
End: args.End,
318+
Checks: []string{string(checkTypeSlowRequests)},
323319
}
324320

325321
investigation := &Investigation{

0 commit comments

Comments
 (0)