Skip to content

Commit aac19c3

Browse files
committed
chore: migrate to Node.js-only install script
Remove install-binary.sh in favor of install-binary.mjs for better cross-platform compatibility. Update plugin.json to use Node.js as the command runner and remove all bash-related workflow tests.
1 parent 5fe855e commit aac19c3

File tree

3 files changed

+2
-176
lines changed

3 files changed

+2
-176
lines changed

.claude-plugin/install-binary.sh

Lines changed: 0 additions & 120 deletions
This file was deleted.

.claude-plugin/plugin.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
"license": "Apache-2.0",
1111
"mcpServers": {
1212
"grafana": {
13-
"command": "${CLAUDE_PLUGIN_ROOT}/.claude-plugin/install-binary.sh",
14-
"args": []
13+
"command": "node",
14+
"args": ["${CLAUDE_PLUGIN_ROOT}/.claude-plugin/install-binary.mjs"]
1515
}
1616
}
1717
}

.github/workflows/test-install-scripts.yml

Lines changed: 0 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -14,38 +14,6 @@ on:
1414
workflow_dispatch:
1515

1616
jobs:
17-
test-bash-script:
18-
name: Test Bash Script
19-
runs-on: ${{ matrix.os }}
20-
strategy:
21-
matrix:
22-
os: [ubuntu-latest, macos-latest]
23-
steps:
24-
- name: Checkout code
25-
uses: actions/checkout@v4
26-
27-
- name: Test bash install script
28-
shell: bash
29-
env:
30-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
31-
run: |
32-
TEMP_DIR=$(mktemp -d)
33-
export CLAUDE_PLUGIN_ROOT="${TEMP_DIR}"
34-
35-
echo "Testing bash install script..."
36-
bash .claude-plugin/install-binary.sh --version
37-
38-
VERSION=$("${TEMP_DIR}/mcp-grafana" --version)
39-
echo "Installed version: ${VERSION}"
40-
41-
if [ -z "${VERSION}" ]; then
42-
echo "Error: Failed to get version"
43-
exit 1
44-
fi
45-
46-
echo "✓ Bash script test passed"
47-
rm -rf "${TEMP_DIR}"
48-
4917
test-nodejs-script:
5018
name: Test Node.js Script
5119
runs-on: ${{ matrix.os }}
@@ -121,28 +89,6 @@ jobs:
12189
with:
12290
node-version: '22'
12391

124-
- name: Test checksum verification with bash
125-
shell: bash
126-
env:
127-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
128-
run: |
129-
TEMP_DIR=$(mktemp -d)
130-
export CLAUDE_PLUGIN_ROOT="${TEMP_DIR}"
131-
132-
echo "Testing checksum verification..."
133-
OUTPUT=$(bash .claude-plugin/install-binary.sh --version 2>&1)
134-
echo "Script output:"
135-
echo "$OUTPUT"
136-
137-
if echo "$OUTPUT" | grep -q "Verifying checksum"; then
138-
echo "✓ Checksum verification executed"
139-
else
140-
echo "Error: Checksum verification not executed"
141-
exit 1
142-
fi
143-
144-
rm -rf "${TEMP_DIR}"
145-
14692
- name: Test checksum verification with Node.js
14793
shell: bash
14894
env:

0 commit comments

Comments
 (0)