PR comments

Author: Dieterbe

mdata/aggmetric.go

@@ -563,7 +563,7 @@ func (a *AggMetric) add(ts uint32, val float64) {
 
 // collectable returns whether the AggMetric is garbage collectable
 // an Aggmetric is collectable based on two conditions:
-// * the AggMetric hasn't been written to in a configurable amount
+// * the AggMetric hasn't been written to in a configurable amount of time
 //   (wether the write went to the ROB or a chunk is irrelevant)
 // * the last chunk - if any - is no longer "active".
 //   active means:

mdata/aggmetrics.go

@@ -62,7 +62,7 @@ func (ms *AggMetrics) GC() {
 			ms.RLock()
 			a := ms.Metrics[key]
 			ms.RUnlock()
-			if stale := a.GC(now, chunkMinTs, metricMinTs); stale {
+			if a.GC(now, chunkMinTs, metricMinTs) {
 				log.Debug("metric %s is stale. Purging data from memory.", key)
 				ms.Lock()
 				delete(ms.Metrics, key)