Commit 155d9dc
authored
Backport 49c3084 from #15018
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Changes HA deduplication behavior in the distributor by no longer
evaluating cluster/replica labels per-series within a write request,
which can alter ingestion outcomes for mixed-label batches. Risk is
mitigated by updated docs but could impact non-standard Prometheus
setups (federation/proxies) that send heterogeneous series in one
request.
>
> **Overview**
> Reverts the distributor HA deduplication optimization that evaluated
HA state per-series, and replaces it with a single HA check based on the
*first* timeseries’ cluster/replica labels, applying the decision
uniformly across the whole request.
>
> This removes the per-replica state tracking/sorting logic and
associated tests/benchmarks, updates `findHALabels` to return `(cluster,
replica)` strings, and updates docs/CHANGELOG to reflect the new
assumption that all series in a request share the same HA labels.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
1c41453. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
1 parent e0c3f73 commit 155d9dc
6 files changed
Lines changed: 77 additions & 932 deletions
File tree
- docs/sources/mimir/configure
- pkg/distributor
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | | - | |
158 | 157 | | |
159 | 158 | | |
160 | 159 | | |
| |||
Lines changed: 1 addition & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
| 48 | + | |
56 | 49 | | |
57 | 50 | | |
58 | 51 | | |
| |||
0 commit comments