Skip to content

Commit 3498576

Browse files
rkferreirarkferreira
authored
feature: add kafka raw env option (#14892)
#### What this PR does Add kafka raw env option. ``` kafka: env: - xxxx ``` #### Which issue(s) this PR fixes or relates to Fixes #14891 #### Checklist - [ ] Tests updated. - [ ] Documentation added. - [x] `CHANGELOG.md` updated - the order of entries should be `[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry is not needed, please add the `changelog-not-needed` label to the PR. - [ ] [`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md) updated with experimental features. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes how environment variables are merged/rendered for containers, which can alter pod specs and runtime behavior if users relied on previous env ordering or override behavior. > > **Overview** > Updates the `mimir-distributed` Helm chart to replace Kafka’s `extraEnv` with a new `kafka.env` list that **merges by variable name** into the chart’s default Kafka env vars, allowing selective overrides without dropping the remaining defaults. > > Refactors Kafka’s StatefulSet to build its default env list in-template and render env/envFrom via `mimir.lib.containerEnv`, and updates `containerEnv.tpl` so user-provided env entries override defaults *in-place* (preserving default ordering) while still appending truly new variables. Changelog and generated golden manifests are updated accordingly. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit dc48409. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Signed-off-by: Rodrigo Kellermann <kellermann@gmail.com>
1 parent d967c45 commit 3498576

28 files changed

Lines changed: 202 additions & 270 deletions

File tree

‎operations/helm/charts/mimir-distributed/CHANGELOG.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,11 @@ Entries should be ordered as follows:
2727

2828
Entries should include a reference to the Pull Request that introduced the change.
2929

30+
3031
## main / unreleased
3132

33+
* [CHANGE] Kafka: Removed `kafka.extraEnv`. Use `kafka.env` instead. #14892
34+
* [ENHANCEMENT] Kafka: Add `kafka.env` to let users selectively override default Kafka environment variables by name, following the same merge pattern used by other chart components (`ingester.env`, etc.). Individual defaults can be replaced in-place without discarding the rest of the list. #14892
3235
* [CHANGE] Update minimum supported Kubernetes version to 1.32. This reflects the fact that Grafana does not test with older versions of Kubernetes. #14335
3336
* [CHANGE] Set default memory ballast for ruler to 1GiB to reduce GC pressure during startup. #13376
3437
* [CHANGE] Set docker.io as the default registry for mimir image. #13267

‎operations/helm/charts/mimir-distributed/templates/kafka/kafka-statefulset.yaml‎

Lines changed: 24 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -65,49 +65,30 @@ spec:
6565
- containerPort: 9093
6666
name: controller
6767
protocol: TCP
68-
env:
69-
# Kubernetes expands env variables in lexical order. So "_POD_NAME" (sic) here is so the name was expanded before KAFKA_ADVERTISED_LISTENERS is.
70-
- name: _POD_NAME
71-
valueFrom:
72-
fieldRef:
73-
fieldPath: metadata.name
74-
- name: KAFKA_CLUSTER_ID
75-
value: "{{ .clusterId | default "" }}"
76-
- name: KAFKA_NODE_ID
77-
valueFrom:
78-
fieldRef:
79-
fieldPath: metadata.labels['apps.kubernetes.io/pod-index']
80-
- name: KAFKA_PROCESS_ROLES
81-
value: "broker,controller"
82-
- name: KAFKA_LISTENERS
83-
value: "PLAINTEXT://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093"
84-
- name: KAFKA_ADVERTISED_LISTENERS
85-
value: PLAINTEXT://$(_POD_NAME).{{ include "mimir.resourceName" (dict "ctx" $ "component" "kafka") }}-headless.{{ $.Release.Namespace }}.svc.{{ $.Values.global.clusterDomain }}:9092
86-
- name: KAFKA_CONTROLLER_QUORUM_VOTERS
87-
# Kafka fails to resolve DNS name with a trailing dot, e.g. "example.cluster.local." Thus, "trimSuffix" is here for the clusterDomain.
88-
value: "{{ range $i := until (int $replicas) }}{{ $i }}@{{ include "mimir.resourceName" (dict "ctx" $ "component" "kafka") }}-{{ $i }}.{{ include "mimir.resourceName" (dict "ctx" $ "component" "kafka") }}-headless.{{ $.Release.Namespace }}.svc.{{ trimSuffix "." $.Values.global.clusterDomain }}:9093{{ if lt $i (sub (int $replicas) 1) }},{{ end }}{{ end }}"
89-
- name: KAFKA_CONTROLLER_LISTENER_NAMES
90-
value: "CONTROLLER"
91-
- name: KAFKA_INTER_BROKER_LISTENER_NAME
92-
value: "PLAINTEXT"
93-
- name: KAFKA_LOG_DIRS
94-
value: "/var/lib/kafka/data"
95-
# The "REPLICATION_FACTOR" must be defined so the broker created offsets topic. Otherwise, the Mimir ingesters won't be able to start.
96-
- name: KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR
97-
value: "{{ min 3 $replicas }}"
98-
- name: KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR
99-
value: "{{ min 3 $replicas }}"
100-
- name: KAFKA_TRANSACTION_STATE_LOG_MIN_ISR
101-
value: "{{ min 2 $replicas }}"
102-
- name: KAFKA_LOG_RETENTION_HOURS
103-
value: "{{ .logRetentionHours | default 24 }}"
104-
{{- with .extraEnv }}
105-
{{- toYaml . | nindent 12 }}
106-
{{- end }}
107-
{{- with .extraEnvFrom }}
108-
envFrom:
109-
{{- toYaml . | nindent 12 }}
110-
{{- end }}
68+
{{- $kafkaName := include "mimir.resourceName" (dict "ctx" $ "component" "kafka") -}}
69+
{{- $clusterDomain := $.Values.global.clusterDomain -}}
70+
{{- $namespace := $.Release.Namespace -}}
71+
{{- $quorumVoters := list -}}
72+
{{- range $i := until (int $replicas) -}}
73+
{{- $quorumVoters = append $quorumVoters (printf "%d@%s-%d.%s-headless.%s.svc.%s:9093" $i $kafkaName $i $kafkaName $namespace (trimSuffix "." $clusterDomain)) -}}
74+
{{- end -}}
75+
{{- $defaultEnv := list
76+
(dict "name" "_POD_NAME" "valueFrom" (dict "fieldRef" (dict "fieldPath" "metadata.name")))
77+
(dict "name" "KAFKA_CLUSTER_ID" "value" (.clusterId | default ""))
78+
(dict "name" "KAFKA_NODE_ID" "valueFrom" (dict "fieldRef" (dict "fieldPath" "metadata.labels['apps.kubernetes.io/pod-index']")))
79+
(dict "name" "KAFKA_PROCESS_ROLES" "value" "broker,controller")
80+
(dict "name" "KAFKA_LISTENERS" "value" "PLAINTEXT://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093")
81+
(dict "name" "KAFKA_ADVERTISED_LISTENERS" "value" (printf "PLAINTEXT://$(_POD_NAME).%s-headless.%s.svc.%s:9092" $kafkaName $namespace $clusterDomain))
82+
(dict "name" "KAFKA_CONTROLLER_QUORUM_VOTERS" "value" (join "," $quorumVoters))
83+
(dict "name" "KAFKA_CONTROLLER_LISTENER_NAMES" "value" "CONTROLLER")
84+
(dict "name" "KAFKA_INTER_BROKER_LISTENER_NAME" "value" "PLAINTEXT")
85+
(dict "name" "KAFKA_LOG_DIRS" "value" "/var/lib/kafka/data")
86+
(dict "name" "KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR" "value" (min 3 $replicas | toString))
87+
(dict "name" "KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR" "value" (min 3 $replicas | toString))
88+
(dict "name" "KAFKA_TRANSACTION_STATE_LOG_MIN_ISR" "value" (min 2 $replicas | toString))
89+
(dict "name" "KAFKA_LOG_RETENTION_HOURS" "value" (.logRetentionHours | default 24 | toString))
90+
-}}
91+
{{- include "mimir.lib.containerEnv" (dict "ctx" $ "component" "kafka" "env" $defaultEnv) | nindent 10 }}
11192
resources:
11293
{{- toYaml .resources | nindent 12 }}
11394
securityContext:

‎operations/helm/charts/mimir-distributed/templates/lib/containerEnv.tpl‎

Lines changed: 24 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ The order of precedence is as follows (high to low):
44
1. Component-specific values
55
2. Global values
66
3. The provided defaults (if any)
7+
The order of the defaults list is preserved; user overrides that match a default
8+
are applied in-place rather than appended.
79
Outputs the complete env/envFrom section for a container manifest.
810
Params:
911
ctx = . context
@@ -12,19 +14,32 @@ Params:
1214
*/}}
1315
{{- define "mimir.lib.containerEnv" -}}
1416
{{- $componentSection := include "mimir.componentSectionFromName" . | fromYaml -}}
15-
{{- $envKV := dict -}}
16-
{{- range (.env | default list) -}}
17-
{{- $_ := set $envKV .name . -}}
18-
{{- end -}}
17+
{{- /* Build a name→entry lookup from user overrides.
18+
global.extraEnv is applied first, component.env second so component.env wins (highest precedence). */ -}}
19+
{{- $overridesKV := dict -}}
1920
{{- range (.ctx.Values.global.extraEnv | default list) -}}
20-
{{- $_ := set $envKV .name . -}}
21+
{{- $_ := set $overridesKV .name . -}}
2122
{{- end -}}
2223
{{- range ($componentSection.env | default list) -}}
23-
{{- $_ := set $envKV .name . -}}
24+
{{- $_ := set $overridesKV .name . -}}
2425
{{- end -}}
26+
{{- /* Walk defaults in their original order so the required ordering is preserved.
27+
Apply the user override for a given name in-place rather than appending at the end. */ -}}
28+
{{- $defaultNames := dict -}}
2529
{{- $envList := list -}}
26-
{{- range $_, $envVar := $envKV -}}
27-
{{- $envList = append $envList $envVar -}}
30+
{{- range (.env | default list) -}}
31+
{{- $_ := set $defaultNames .name true -}}
32+
{{- if hasKey $overridesKV .name -}}
33+
{{- $envList = append $envList (index $overridesKV .name) -}}
34+
{{- else -}}
35+
{{- $envList = append $envList . -}}
36+
{{- end -}}
37+
{{- end -}}
38+
{{- /* Append user-defined vars that are not overrides of an existing default. */ -}}
39+
{{- range $name, $envVar := $overridesKV -}}
40+
{{- if not (hasKey $defaultNames $name) -}}
41+
{{- $envList = append $envList $envVar -}}
42+
{{- end -}}
2843
{{- end -}}
2944
env:
3045
{{- toYaml $envList | nindent 2 }}
@@ -34,7 +49,7 @@ envFrom:
3449
{{- toYaml . | nindent 2 -}}
3550
{{- end }}
3651
{{- with $componentSection.extraEnvFrom }}
37-
{{- toYaml . | nindent 12 }}
52+
{{- toYaml . | nindent 2 }}
3853
{{- end }}
3954
{{- end }}
4055
{{- end -}}

‎operations/helm/charts/mimir-distributed/values.yaml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3121,8 +3121,10 @@ kafka:
31213121
terminationGracePeriodSeconds: 30
31223122
# -- Kafka log retention period in hours
31233123
logRetentionHours: 24
3124-
# -- Additional environment variables for Kafka
3125-
extraEnv: []
3124+
# -- Additional environment variables for Kafka.
3125+
# Entries are merged by name into the default Kafka env vars, following the same pattern as other chart components.
3126+
# A user-provided entry with the same name as a default overrides the default in-place (preserving list order).
3127+
env: []
31263128
# -- Additional environment variables from secrets or configmaps
31273129
extraEnvFrom: []
31283130

‎operations/helm/tests/gateway-nginx-values-generated/mimir-distributed/templates/kafka/kafka-statefulset.yaml‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ spec:
5252
name: controller
5353
protocol: TCP
5454
env:
55-
# Kubernetes expands env variables in lexical order. So "_POD_NAME" (sic) here is so the name was expanded before KAFKA_ADVERTISED_LISTENERS is.
5655
- name: _POD_NAME
5756
valueFrom:
5857
fieldRef:
@@ -64,21 +63,19 @@ spec:
6463
fieldRef:
6564
fieldPath: metadata.labels['apps.kubernetes.io/pod-index']
6665
- name: KAFKA_PROCESS_ROLES
67-
value: "broker,controller"
66+
value: broker,controller
6867
- name: KAFKA_LISTENERS
69-
value: "PLAINTEXT://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093"
68+
value: PLAINTEXT://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093
7069
- name: KAFKA_ADVERTISED_LISTENERS
7170
value: PLAINTEXT://$(_POD_NAME).gateway-nginx-values-mimir-kafka-headless.citestns.svc.cluster.local.:9092
7271
- name: KAFKA_CONTROLLER_QUORUM_VOTERS
73-
# Kafka fails to resolve DNS name with a trailing dot, e.g. "example.cluster.local." Thus, "trimSuffix" is here for the clusterDomain.
74-
value: "0@gateway-nginx-values-mimir-kafka-0.gateway-nginx-values-mimir-kafka-headless.citestns.svc.cluster.local:9093"
72+
value: 0@gateway-nginx-values-mimir-kafka-0.gateway-nginx-values-mimir-kafka-headless.citestns.svc.cluster.local:9093
7573
- name: KAFKA_CONTROLLER_LISTENER_NAMES
76-
value: "CONTROLLER"
74+
value: CONTROLLER
7775
- name: KAFKA_INTER_BROKER_LISTENER_NAME
78-
value: "PLAINTEXT"
76+
value: PLAINTEXT
7977
- name: KAFKA_LOG_DIRS
80-
value: "/var/lib/kafka/data"
81-
# The "REPLICATION_FACTOR" must be defined so the broker created offsets topic. Otherwise, the Mimir ingesters won't be able to start.
78+
value: /var/lib/kafka/data
8279
- name: KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR
8380
value: "1"
8481
- name: KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR

‎operations/helm/tests/keda-autoscaling-global-values-generated/mimir-distributed/templates/kafka/kafka-statefulset.yaml‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ spec:
5252
name: controller
5353
protocol: TCP
5454
env:
55-
# Kubernetes expands env variables in lexical order. So "_POD_NAME" (sic) here is so the name was expanded before KAFKA_ADVERTISED_LISTENERS is.
5655
- name: _POD_NAME
5756
valueFrom:
5857
fieldRef:
@@ -64,21 +63,19 @@ spec:
6463
fieldRef:
6564
fieldPath: metadata.labels['apps.kubernetes.io/pod-index']
6665
- name: KAFKA_PROCESS_ROLES
67-
value: "broker,controller"
66+
value: broker,controller
6867
- name: KAFKA_LISTENERS
69-
value: "PLAINTEXT://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093"
68+
value: PLAINTEXT://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093
7069
- name: KAFKA_ADVERTISED_LISTENERS
7170
value: PLAINTEXT://$(_POD_NAME).keda-autoscaling-global-values-mimir-kafka-headless.citestns.svc.cluster.local.:9092
7271
- name: KAFKA_CONTROLLER_QUORUM_VOTERS
73-
# Kafka fails to resolve DNS name with a trailing dot, e.g. "example.cluster.local." Thus, "trimSuffix" is here for the clusterDomain.
74-
value: "0@keda-autoscaling-global-values-mimir-kafka-0.keda-autoscaling-global-values-mimir-kafka-headless.citestns.svc.cluster.local:9093"
72+
value: 0@keda-autoscaling-global-values-mimir-kafka-0.keda-autoscaling-global-values-mimir-kafka-headless.citestns.svc.cluster.local:9093
7573
- name: KAFKA_CONTROLLER_LISTENER_NAMES
76-
value: "CONTROLLER"
74+
value: CONTROLLER
7775
- name: KAFKA_INTER_BROKER_LISTENER_NAME
78-
value: "PLAINTEXT"
76+
value: PLAINTEXT
7977
- name: KAFKA_LOG_DIRS
80-
value: "/var/lib/kafka/data"
81-
# The "REPLICATION_FACTOR" must be defined so the broker created offsets topic. Otherwise, the Mimir ingesters won't be able to start.
78+
value: /var/lib/kafka/data
8279
- name: KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR
8380
value: "1"
8481
- name: KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR

‎operations/helm/tests/keda-autoscaling-metamonitoring-values-generated/mimir-distributed/templates/kafka/kafka-statefulset.yaml‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ spec:
5252
name: controller
5353
protocol: TCP
5454
env:
55-
# Kubernetes expands env variables in lexical order. So "_POD_NAME" (sic) here is so the name was expanded before KAFKA_ADVERTISED_LISTENERS is.
5655
- name: _POD_NAME
5756
valueFrom:
5857
fieldRef:
@@ -64,21 +63,19 @@ spec:
6463
fieldRef:
6564
fieldPath: metadata.labels['apps.kubernetes.io/pod-index']
6665
- name: KAFKA_PROCESS_ROLES
67-
value: "broker,controller"
66+
value: broker,controller
6867
- name: KAFKA_LISTENERS
69-
value: "PLAINTEXT://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093"
68+
value: PLAINTEXT://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093
7069
- name: KAFKA_ADVERTISED_LISTENERS
7170
value: PLAINTEXT://$(_POD_NAME).keda-autoscaling-metamonitoring-values-mimir-kafka-headless.citestns.svc.cluster.local.:9092
7271
- name: KAFKA_CONTROLLER_QUORUM_VOTERS
73-
# Kafka fails to resolve DNS name with a trailing dot, e.g. "example.cluster.local." Thus, "trimSuffix" is here for the clusterDomain.
74-
value: "0@keda-autoscaling-metamonitoring-values-mimir-kafka-0.keda-autoscaling-metamonitoring-values-mimir-kafka-headless.citestns.svc.cluster.local:9093"
72+
value: 0@keda-autoscaling-metamonitoring-values-mimir-kafka-0.keda-autoscaling-metamonitoring-values-mimir-kafka-headless.citestns.svc.cluster.local:9093
7573
- name: KAFKA_CONTROLLER_LISTENER_NAMES
76-
value: "CONTROLLER"
74+
value: CONTROLLER
7775
- name: KAFKA_INTER_BROKER_LISTENER_NAME
78-
value: "PLAINTEXT"
76+
value: PLAINTEXT
7977
- name: KAFKA_LOG_DIRS
80-
value: "/var/lib/kafka/data"
81-
# The "REPLICATION_FACTOR" must be defined so the broker created offsets topic. Otherwise, the Mimir ingesters won't be able to start.
78+
value: /var/lib/kafka/data
8279
- name: KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR
8380
value: "1"
8481
- name: KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR

‎operations/helm/tests/keda-autoscaling-values-generated/mimir-distributed/templates/kafka/kafka-statefulset.yaml‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ spec:
5252
name: controller
5353
protocol: TCP
5454
env:
55-
# Kubernetes expands env variables in lexical order. So "_POD_NAME" (sic) here is so the name was expanded before KAFKA_ADVERTISED_LISTENERS is.
5655
- name: _POD_NAME
5756
valueFrom:
5857
fieldRef:
@@ -64,21 +63,19 @@ spec:
6463
fieldRef:
6564
fieldPath: metadata.labels['apps.kubernetes.io/pod-index']
6665
- name: KAFKA_PROCESS_ROLES
67-
value: "broker,controller"
66+
value: broker,controller
6867
- name: KAFKA_LISTENERS
69-
value: "PLAINTEXT://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093"
68+
value: PLAINTEXT://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093
7069
- name: KAFKA_ADVERTISED_LISTENERS
7170
value: PLAINTEXT://$(_POD_NAME).keda-autoscaling-values-mimir-kafka-headless.citestns.svc.cluster.local.:9092
7271
- name: KAFKA_CONTROLLER_QUORUM_VOTERS
73-
# Kafka fails to resolve DNS name with a trailing dot, e.g. "example.cluster.local." Thus, "trimSuffix" is here for the clusterDomain.
74-
value: "0@keda-autoscaling-values-mimir-kafka-0.keda-autoscaling-values-mimir-kafka-headless.citestns.svc.cluster.local:9093"
72+
value: 0@keda-autoscaling-values-mimir-kafka-0.keda-autoscaling-values-mimir-kafka-headless.citestns.svc.cluster.local:9093
7573
- name: KAFKA_CONTROLLER_LISTENER_NAMES
76-
value: "CONTROLLER"
74+
value: CONTROLLER
7775
- name: KAFKA_INTER_BROKER_LISTENER_NAME
78-
value: "PLAINTEXT"
76+
value: PLAINTEXT
7977
- name: KAFKA_LOG_DIRS
80-
value: "/var/lib/kafka/data"
81-
# The "REPLICATION_FACTOR" must be defined so the broker created offsets topic. Otherwise, the Mimir ingesters won't be able to start.
78+
value: /var/lib/kafka/data
8279
- name: KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR
8380
value: "1"
8481
- name: KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR

‎operations/helm/tests/large-values-generated/mimir-distributed/templates/kafka/kafka-statefulset.yaml‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ spec:
5252
name: controller
5353
protocol: TCP
5454
env:
55-
# Kubernetes expands env variables in lexical order. So "_POD_NAME" (sic) here is so the name was expanded before KAFKA_ADVERTISED_LISTENERS is.
5655
- name: _POD_NAME
5756
valueFrom:
5857
fieldRef:
@@ -64,21 +63,19 @@ spec:
6463
fieldRef:
6564
fieldPath: metadata.labels['apps.kubernetes.io/pod-index']
6665
- name: KAFKA_PROCESS_ROLES
67-
value: "broker,controller"
66+
value: broker,controller
6867
- name: KAFKA_LISTENERS
69-
value: "PLAINTEXT://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093"
68+
value: PLAINTEXT://0.0.0.0:9092,CONTROLLER://0.0.0.0:9093
7069
- name: KAFKA_ADVERTISED_LISTENERS
7170
value: PLAINTEXT://$(_POD_NAME).large-values-mimir-kafka-headless.citestns.svc.cluster.local.:9092
7271
- name: KAFKA_CONTROLLER_QUORUM_VOTERS
73-
# Kafka fails to resolve DNS name with a trailing dot, e.g. "example.cluster.local." Thus, "trimSuffix" is here for the clusterDomain.
74-
value: "0@large-values-mimir-kafka-0.large-values-mimir-kafka-headless.citestns.svc.cluster.local:9093"
72+
value: 0@large-values-mimir-kafka-0.large-values-mimir-kafka-headless.citestns.svc.cluster.local:9093
7573
- name: KAFKA_CONTROLLER_LISTENER_NAMES
76-
value: "CONTROLLER"
74+
value: CONTROLLER
7775
- name: KAFKA_INTER_BROKER_LISTENER_NAME
78-
value: "PLAINTEXT"
76+
value: PLAINTEXT
7977
- name: KAFKA_LOG_DIRS
80-
value: "/var/lib/kafka/data"
81-
# The "REPLICATION_FACTOR" must be defined so the broker created offsets topic. Otherwise, the Mimir ingesters won't be able to start.
78+
value: /var/lib/kafka/data
8279
- name: KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR
8380
value: "1"
8481
- name: KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR

0 commit comments

Comments
 (0)