Commit ef9e72e
authored
Update dskit to support loading runtime configs from HTTP endpoints (#15052)
#### What this PR does
Update dskit to get grafana/dskit#926.
That change lets the runtimeconfig Manager load configuration from
`http://` and `https://` URLs in addition to local files, so
`-runtime-config.file` now accepts URLs. It also adds the
`-runtime-config.http-client-timeout` flag (default `30s`) for the HTTP
fetch timeout.
#### Which issue(s) this PR fixes or relates to
N/A
#### Checklist
- [ ] Tests updated.
- [x] Documentation added.
- [x] `CHANGELOG.md` updated - the order of entries should be
`[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry
is not needed, please add the `changelog-not-needed` label to the PR.
- [ ]
[`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md)
updated with experimental features.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Changes runtime-config loading to perform HTTP requests and adds new
timeout/metrics, which can affect startup/reload behavior and introduce
network-related failure modes.
>
> **Overview**
> **Runtime config loading now supports remote sources.**
`-runtime-config.file` can point to `http://`/`https://` URLs as well as
local files, via a new provider abstraction in the vendored `dskit`
runtimeconfig manager.
>
> Adds `-runtime-config.http-client-timeout` (default `30s`) and a
`runtime_config_http_request_duration_seconds` metric for HTTP fetch
latency, and updates generated config/help docs plus `CHANGELOG.md`
accordingly.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
1dd09da. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 37b04a0 commit ef9e72e
11 files changed
Lines changed: 201 additions & 34 deletions
File tree
- cmd/mimir
- docs/sources/mimir/configure/configuration-parameters
- operations/mimir
- vendor
- github.com/grafana/dskit/runtimeconfig
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
37 | 38 | | |
38 | 39 | | |
39 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18683 | 18683 | | |
18684 | 18684 | | |
18685 | 18685 | | |
18686 | | - | |
| 18686 | + | |
18687 | 18687 | | |
18688 | 18688 | | |
18689 | 18689 | | |
18690 | 18690 | | |
| 18691 | + | |
| 18692 | + | |
| 18693 | + | |
| 18694 | + | |
| 18695 | + | |
| 18696 | + | |
| 18697 | + | |
| 18698 | + | |
| 18699 | + | |
| 18700 | + | |
| 18701 | + | |
18691 | 18702 | | |
18692 | 18703 | | |
18693 | 18704 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3282 | 3282 | | |
3283 | 3283 | | |
3284 | 3284 | | |
3285 | | - | |
| 3285 | + | |
| 3286 | + | |
| 3287 | + | |
3286 | 3288 | | |
3287 | 3289 | | |
3288 | 3290 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
840 | 840 | | |
841 | 841 | | |
842 | 842 | | |
843 | | - | |
| 843 | + | |
844 | 844 | | |
845 | 845 | | |
846 | 846 | | |
| |||
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
342 | 342 | | |
343 | 343 | | |
344 | 344 | | |
345 | | - | |
346 | | - | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
347 | 348 | | |
348 | 349 | | |
349 | 350 | | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
350 | 355 | | |
351 | 356 | | |
352 | 357 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
585 | 585 | | |
586 | 586 | | |
587 | 587 | | |
588 | | - | |
589 | | - | |
| 588 | + | |
| 589 | + | |
590 | 590 | | |
591 | 591 | | |
592 | 592 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1328 | 1328 | | |
1329 | 1329 | | |
1330 | 1330 | | |
| 1331 | + | |
1331 | 1332 | | |
1332 | 1333 | | |
1333 | 1334 | | |
| |||
Lines changed: 47 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 125 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments