-
Notifications
You must be signed in to change notification settings - Fork 34
Description
Which package(s) does this bug affect?
- Create Plugin
- Sign Plugin
- Plugin E2E
- Plugin Meta Extractor
- Plugin ESLint Rules
Package versions
What happened?
We scaffolded an app plugin that has a panel plugin located within a panel folder in the plugin (nesting two different plugins). When the panel tries to lazily load dependencies it try to fetch them from the following path:
GET /public/plugins/grafana-medtech-panel
But with the current build config the vendor dependencies are placed in the dist
folder of the root app plugin. So if I change the path to:
GET /public/plugins/grafana-medtech-app
I can fetch the dependency successfully. I guess in this edge case we should try to fetch all lazily loaded plugins from the root plugin path instead of the path of the nested plugin.
What you expected to happen
It should load all dependencies successfully. I'm not sure what the right call is here.
I guess we have two options:
- Make sure that for nested plugins we try to fetch all dependencies from the root plugin path.
- When building a plugin with nested plugins in it: emit the dependencies in the nested plugin's path.
How to reproduce it (as minimally and precisely as possible)
- Clone this repo and use the linked commit: https://github.com/hugohaggmark/grafana-medtech-app/tree/e275a66120bd56a56896af55db14c2be1b44cbac
- npm i && mage -v
- npm run dev
- docker compose up
- Go into the provisioned dashboard and check the network tab.
Environment
n/a
Additional context
No response
Metadata
Metadata
Assignees
Labels
Type
Projects
Status