[release/v1.12] Update golang version to 1.23.8 (#4115)

korniltsev · simonswine · web-flow · commit 1c8d6bdb8ce6 · 2025-04-17T09:43:55.000+07:00
Backport b0a4a4f from #4106 Backport #3996 Backport #4019 * Update golang version to 1.23.8 * manually update examples go.work to go 1.23.0 * Remove doc-validator (#3996) * chore: Remove qemu ebpf tests (#4019) They are failing since some time and we are planning to migrate to ebpf-profiler from open-telemetry. --------- Co-authored-by: Christian Simon <simon@swine.de>
diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml
@@ -25,7 +25,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.23.7"
+          go-version: "1.23.8"
           cache: true
       - run: yarn --frozen-lockfile
       - run: make build
@@ -55,7 +55,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.23.7"
+          go-version: "1.23.8"
           cache: true
       - run: yarn --frozen-lockfile
       - run: make build
diff --git a/.github/workflows/fuzzer.yml b/.github/workflows/fuzzer.yml
@@ -13,6 +13,6 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.23.7
+          go-version: 1.23.8
       - name: Run Fuzz_Merge_Single
         run: go test -fuzz=Fuzz_Merge_Single --fuzztime 1h -run '^$' -v ./pkg/pprof/
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -28,7 +28,7 @@ jobs:
       - run: git fetch --force --tags
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23.7"
+          go-version: "1.23.8"
           cache: true
       - uses: actions/setup-node@v3
         with:
diff --git a/.github/workflows/test-examples.yml b/.github/workflows/test-examples.yml
@@ -20,6 +20,6 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.23.7
+          go-version: 1.23.8
       - name: Run tests
         run: make examples/test
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -22,7 +22,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.23.7
+          go-version: 1.23.8
       - name: Format
         run: make fmt check/unstaged-changes
   check-generated:
@@ -33,7 +33,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.23.7
+          go-version: 1.23.8
       - name: Check generated files
         run: make generate check/unstaged-changes
   test:
@@ -44,7 +44,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.23.7
+          go-version: 1.23.8
       - name: Go Mod
         run: make check/go/mod
       - name: Test
@@ -57,7 +57,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.23.7
+          go-version: 1.23.8
       - name: Run linter
         run: make lint
       - name: Check helm manifests
@@ -71,28 +71,6 @@ jobs:
       - name: "Test docs"
         run: make docs/test
 
-  doc-validator:
-    runs-on: "ubuntu-latest"
-    container:
-      image: "grafana/doc-validator:v5.2.0"
-    steps:
-      - name: "Checkout code"
-        uses: "actions/checkout@v4"
-      - name: "Run doc-validator tool"
-        run: >
-          doc-validator
-          '--skip-checks=^image.+$'
-          docs/sources
-          /docs/writers-toolkit
-          | reviewdog
-          -f=rdjsonl
-          --fail-on-error
-          --filter-mode=nofilter
-          --name=doc-validator
-          --reporter=github-pr-review
-        env:
-          REVIEWDOG_GITHUB_API_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
-
   build-image:
     if: github.event_name != 'push'
     runs-on: ubuntu-latest
@@ -107,7 +85,7 @@ jobs:
       - name: Set up go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.23.7
+          go-version: 1.23.8
       - uses: actions/setup-node@v3
         with:
           node-version: 20
@@ -129,7 +107,7 @@ jobs:
       - name: Set up go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.23.7
+          go-version: 1.23.8
       - uses: actions/setup-node@v3
         with:
           node-version: lts/hydrogen
diff --git a/.github/workflows/test_ebpf.yml b/.github/workflows/test_ebpf.yml
@@ -27,77 +27,6 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v5
         with:
-          go-version: 1.23.7
+          go-version: 1.23.8
       - name: Test
         run: sudo make -C ./ebpf go/test/amd64
-  test_ebpf_qemu:
-    name: on QEMU
-    runs-on: ubuntu-latest-16-cores
-    strategy:
-      matrix:
-        include:
-#          - arch: amd64 # https://github.com/grafana/pyroscope/issues/3033
-#            kernel: amd64/boot/vmlinuz-4.19.0-26-amd64
-#            initrd: amd64/boot/initrd.img-4.19.0-26-amd64
-          - arch: amd64
-            kernel: amd64/boot/vmlinuz-5.10.0-28-amd64
-            initrd: amd64/boot/initrd.img-5.10.0-28-amd64
-          - arch: amd64
-            kernel: amd64/boot/vmlinuz-5.15.0-94-generic
-            initrd: amd64/boot/initrd.img-5.15.0-94-generic
-          - arch: amd64
-            kernel: amd64/boot/vmlinuz-5.4.0-150-generic
-            initrd: amd64/boot/initrd.img-5.4.0-150-generic
-          - arch: amd64
-            kernel: amd64/boot/vmlinuz-6.1.0-18-amd64
-            initrd: amd64/boot/initrd.img-6.1.0-18-amd64
-          - arch: amd64
-            kernel: amd64/boot_extra/vmlinuz-5.10.205-195.807.amzn2.x86_64
-            initrd: amd64/boot_extra/initramfs-5.10.205-195.807.amzn2.x86_64.img
-
-#          - arch: arm64 # https://github.com/grafana/pyroscope/issues/3033
-#            kernel: arm64/boot/vmlinuz-4.19.0-26-arm64
-#            initrd: arm64/boot/initrd.img-4.19.0-26-arm64
-          - arch: arm64
-            kernel: arm64/boot/vmlinuz-5.10.0-28-arm64
-            initrd: arm64/boot/initrd.img-5.10.0-28-arm64
-          - arch: arm64
-            kernel: arm64/boot/vmlinuz-5.15.0-94-generic
-            initrd: arm64/boot/initrd.img-5.15.0-94-generic
-          - arch: arm64
-            kernel: arm64/boot/vmlinuz-5.4.0-150-generic
-            initrd: arm64/boot/initrd.img-5.4.0-150-generic
-          - arch: arm64
-            kernel: arm64/boot/vmlinuz-6.1.0-18-arm64
-            initrd: arm64/boot/initrd.img-6.1.0-18-arm64
-          - arch: arm64
-            kernel: arm64/boot_extra/vmlinuz-5.10.205-195.807.amzn2.aarch64
-            initrd: arm64/boot_extra/initramfs-5.10.205-195.807.amzn2.aarch64.img
-
-    steps:
-      - name: Checkout code with submodule
-        uses: actions/checkout@v4
-        with:
-          submodules: recursive
-      - name: Install Go
-        uses: actions/setup-go@v5
-        with:
-          go-version: 1.23.7
-      - name: Install qemu
-        run: sudo apt-get update && sudo apt-get -y install qemu-system-x86 qemu-system-aarch64
-      - name: Build tests
-        run: make -C ./ebpf ebpf.${{ matrix.arch }}.test
-      - name: Pull VM image
-        run: make -C ./ebpf/testdata/qemu_img dist/pull
-      - name: Start VM
-        run: >
-          KVM_ARGS="" ARCH=${{ matrix.arch }} KERNEL=${{ matrix.kernel }} INITRD=${{ matrix.initrd }} make -C ./ebpf/testdata/qemu_img qemu/start_and_wait
-      - name: Copy test binary
-        run: >
-          F=$(realpath ./ebpf/ebpf.${{ matrix.arch }}.test) make -C ./ebpf/testdata/qemu_img qemu/scp
-      - name: Uname
-        run: >
-          CMD="uname -a"  make -C ./ebpf/testdata/qemu_img qemu/exec
-      - name: Run tests
-        run: >
-          CMD=./ebpf.${{ matrix.arch }}.test make -C ./ebpf/testdata/qemu_img qemu/exec
diff --git a/.github/workflows/weekly-release.yml b/.github/workflows/weekly-release.yml
@@ -27,7 +27,7 @@ jobs:
           git tag "$WEEKLY_IMAGE_TAG"
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.23.7"
+          go-version: "1.23.8"
           cache: true
       # setup docker buildx
       - name: Set up QEMU
diff --git a/.goreleaser.yaml b/.goreleaser.yaml
@@ -3,7 +3,7 @@ version: 2
 before:
   hooks:
     # This hook ensures that goreleaser uses the correct go version for a Pyroscope release
-    - sh -euc 'go version | grep "go version go1.23.7 " || { echo "Unexpected go version"; exit 1; }'
+    - sh -euc 'go version | grep "go version go1.23.8 " || { echo "Unexpected go version"; exit 1; }'
 env:
   # Strip debug information from the binary by default, weekly builds will have debug information
   - GORELEASER_DEBUG_INFO_FLAGS={{ if and (index .Env "GORELEASER_STRIP_DEBUG_INFO") (eq .Env.GORELEASER_STRIP_DEBUG_INFO "false")  }}{{ else }}-s -w{{ end }}
diff --git a/api/go.mod b/api/go.mod
@@ -2,7 +2,6 @@ module github.com/grafana/pyroscope/api
 
 go 1.23.0
 
-
 require (
 	connectrpc.com/connect v1.16.2
 	github.com/gogo/protobuf v1.3.2
diff --git a/ebpf/go.mod b/ebpf/go.mod
@@ -2,7 +2,6 @@ module github.com/grafana/pyroscope/ebpf
 
 go 1.23.0
 
-
 require (
 	connectrpc.com/connect v1.16.2
 	github.com/avvmoto/buf-readerat v0.0.0-20171115124131-a17c8cb89270
diff --git a/examples/golang-pgo/Dockerfile b/examples/golang-pgo/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.7
+FROM golang:1.23.8
 
 WORKDIR /go/src/app
 COPY . .
diff --git a/examples/golang-pgo/go.mod b/examples/golang-pgo/go.mod
@@ -2,7 +2,6 @@ module rideshare
 
 go 1.23.0
 
-
 require (
 	github.com/agoda-com/opentelemetry-logs-go v0.5.1
 	github.com/grafana/otel-profiling-go v0.5.1
diff --git a/examples/golang-pgo/go.work b/examples/golang-pgo/go.work
@@ -1,4 +1,4 @@
-go 1.22
+go 1.23.0
 
 
 use .
diff --git a/examples/language-sdk-instrumentation/golang-push/rideshare-alloy/Dockerfile b/examples/language-sdk-instrumentation/golang-push/rideshare-alloy/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.7
+FROM golang:1.23.8
 
 WORKDIR /go/src/app
 COPY . .
diff --git a/examples/language-sdk-instrumentation/golang-push/rideshare-alloy/Dockerfile.load-generator b/examples/language-sdk-instrumentation/golang-push/rideshare-alloy/Dockerfile.load-generator
@@ -1,4 +1,4 @@
-FROM golang:1.23.7
+FROM golang:1.23.8
 
 WORKDIR /go/src/app
 COPY . .
diff --git a/examples/language-sdk-instrumentation/golang-push/rideshare-alloy/go.mod b/examples/language-sdk-instrumentation/golang-push/rideshare-alloy/go.mod
@@ -2,7 +2,6 @@ module rideshare
 
 go 1.23.0
 
-
 require (
 	github.com/agoda-com/opentelemetry-logs-go v0.4.1
 	github.com/grafana/otel-profiling-go v0.5.1
diff --git a/examples/language-sdk-instrumentation/golang-push/rideshare-alloy/go.work b/examples/language-sdk-instrumentation/golang-push/rideshare-alloy/go.work
@@ -1,4 +1,4 @@
-go 1.22
+go 1.23.0
 
 
 use .
diff --git a/examples/language-sdk-instrumentation/golang-push/rideshare-k6/Dockerfile b/examples/language-sdk-instrumentation/golang-push/rideshare-k6/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.7
+FROM golang:1.23.8
 
 WORKDIR /go/src/app
 COPY . .
diff --git a/examples/language-sdk-instrumentation/golang-push/rideshare-k6/Dockerfile.load-generator b/examples/language-sdk-instrumentation/golang-push/rideshare-k6/Dockerfile.load-generator
@@ -1,4 +1,4 @@
-FROM golang:1.23.7
+FROM golang:1.23.8
 
 WORKDIR /go/src/app
 COPY . .
diff --git a/examples/language-sdk-instrumentation/golang-push/rideshare-k6/go.mod b/examples/language-sdk-instrumentation/golang-push/rideshare-k6/go.mod
@@ -2,7 +2,6 @@ module rideshare
 
 go 1.23.0
 
-
 require (
 	github.com/agoda-com/opentelemetry-logs-go v0.4.1
 	github.com/grafana/otel-profiling-go v0.5.1
diff --git a/examples/language-sdk-instrumentation/golang-push/rideshare-k6/go.work b/examples/language-sdk-instrumentation/golang-push/rideshare-k6/go.work
@@ -1,4 +1,4 @@
-go 1.22
+go 1.23.0
 
 
 use .
diff --git a/examples/language-sdk-instrumentation/golang-push/rideshare/Dockerfile b/examples/language-sdk-instrumentation/golang-push/rideshare/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.7
+FROM golang:1.23.8
 
 WORKDIR /go/src/app
 COPY . .
diff --git a/examples/language-sdk-instrumentation/golang-push/rideshare/Dockerfile.load-generator b/examples/language-sdk-instrumentation/golang-push/rideshare/Dockerfile.load-generator
@@ -1,4 +1,4 @@
-FROM golang:1.23.7
+FROM golang:1.23.8
 
 WORKDIR /go/src/app
 COPY . .
diff --git a/examples/language-sdk-instrumentation/golang-push/rideshare/go.mod b/examples/language-sdk-instrumentation/golang-push/rideshare/go.mod
@@ -2,7 +2,6 @@ module rideshare
 
 go 1.23.0
 
-
 require (
 	github.com/agoda-com/opentelemetry-logs-go v0.5.1
 	github.com/grafana/otel-profiling-go v0.5.1
diff --git a/examples/language-sdk-instrumentation/golang-push/rideshare/go.work b/examples/language-sdk-instrumentation/golang-push/rideshare/go.work
@@ -1,4 +1,4 @@
-go 1.22
+go 1.23.0
 
 
 use .
diff --git a/examples/language-sdk-instrumentation/golang-push/simple/Dockerfile b/examples/language-sdk-instrumentation/golang-push/simple/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.7
+FROM golang:1.23.8
 
 WORKDIR /go/src/app
 
diff --git a/examples/language-sdk-instrumentation/golang-push/simple/go.mod b/examples/language-sdk-instrumentation/golang-push/simple/go.mod
@@ -2,7 +2,6 @@ module pushsimple
 
 go 1.23.0
 
-
 require github.com/grafana/pyroscope-go v1.2.0
 
 require (
diff --git a/examples/language-sdk-instrumentation/golang-push/simple/go.work b/examples/language-sdk-instrumentation/golang-push/simple/go.work
@@ -1,3 +1,3 @@
-go 1.22
+go 1.23.0
 
 use .
diff --git a/examples/tracing/golang-push/Dockerfile b/examples/tracing/golang-push/Dockerfile
@@ -1,4 +1,4 @@
-FROM golang:1.23.7
+FROM golang:1.23.8
 
 WORKDIR /go/src/app
 COPY . .
diff --git a/examples/tracing/golang-push/Dockerfile.load-generator b/examples/tracing/golang-push/Dockerfile.load-generator
@@ -1,4 +1,4 @@
-FROM golang:1.23.7
+FROM golang:1.23.8
 
 WORKDIR /go/src/app
 COPY . .
diff --git a/examples/tracing/golang-push/go.mod b/examples/tracing/golang-push/go.mod
@@ -2,7 +2,6 @@ module rideshare
 
 go 1.23.0
 
-
 require (
 	github.com/agoda-com/opentelemetry-logs-go v0.5.1
 	github.com/grafana/otel-profiling-go v0.5.1
diff --git a/examples/tracing/golang-push/go.work b/examples/tracing/golang-push/go.work
@@ -1,4 +1,4 @@
-go 1.22
+go 1.23.0
 
 
 use .
diff --git a/go.mod b/go.mod
@@ -2,7 +2,6 @@ module github.com/grafana/pyroscope
 
 go 1.23.0
 
-
 require (
 	connectrpc.com/connect v1.16.2
 	connectrpc.com/grpchealth v1.3.0
diff --git a/go.work b/go.work
@@ -1,6 +1,5 @@
 go 1.23.0
 
-
 use (
 	.
 	./api

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-FROM golang:1.23.7`
	`1`	`+FROM golang:1.23.8`
`2`	`2`
`3`	`3`	`WORKDIR /go/src/app`
`4`	`4`	`COPY . .`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-go 1.22`
	`1`	`+go 1.23.0`
`2`	`2`
`3`	`3`
`4`	`4`	`use .`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`		`-go 1.22`
	`1`	`+go 1.23.0`
`2`	`2`
`3`	`3`	`use .`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`go 1.23.0`
`2`	`2`
`3`		`-`
`4`	`3`	`use (`
`5`	`4`	`.`
`6`	`5`	`./api`