Update unsymbolized check logic & update label name

Author: marcsanmi

pkg/experiment/block/metadata/metadata_labels.go

@@ -16,9 +16,9 @@ import (
 // TODO(kolesnikovae): LabelBuilder pool.
 
 const (
-	LabelNameTenantDataset                 = "__tenant_dataset__"
-	LabelValueDatasetTSDBIndex             = "dataset_tsdb_index"
-	LabelNameHasNativeUnsymbolizedProfiles = "__has_native_unsymbolized_profiles__"
+	LabelNameTenantDataset     = "__tenant_dataset__"
+	LabelValueDatasetTSDBIndex = "dataset_tsdb_index"
+	LabelNameUnsymbolized      = "__unsymbolized__"
 )
 
 type LabelBuilder struct {

pkg/experiment/ingester/memdb/head.go

@@ -21,11 +21,11 @@ import (
 )
 
 type FlushedHead struct {
-	Index                         []byte
-	Profiles                      []byte
-	Symbols                       []byte
-	HasNativeUnsymbolizedProfiles bool
-	Meta                          struct {
+	Index                   []byte
+	Profiles                []byte
+	Symbols                 []byte
+	HasUnsymbolizedProfiles bool
+	Meta                    struct {
 		ProfileTypeNames []string
 		MinTimeNanos     int64
 		MaxTimeNanos     int64
@@ -154,17 +154,7 @@ func (h *Head) flush(ctx context.Context) (*FlushedHead, error) {
 		return res, nil
 	}
 
-	var HasNativeUnsymbolizedProfiles bool
-	mappings := h.symbols.Symbols().Mappings
-	for i := range mappings {
-		HasNativeUnsymbolizedProfiles = HasNativeUnsymbolizedProfiles || !mappings[i].HasFunctions
-	}
-	locations := h.symbols.Symbols().Locations
-	for i := range locations {
-		HasNativeUnsymbolizedProfiles = HasNativeUnsymbolizedProfiles || len(locations[i].Line) == 0
-	}
-
-	res.HasNativeUnsymbolizedProfiles = HasNativeUnsymbolizedProfiles
+	res.HasUnsymbolizedProfiles = HasUnsymbolizedProfiles(h.symbols.Symbols())
 
 	symbolsBuffer := bytes.NewBuffer(nil)
 	if err := symdb.WritePartition(h.symbols, symbolsBuffer); err != nil {
@@ -186,3 +176,16 @@ func (h *Head) flush(ctx context.Context) (*FlushedHead, error) {
 	}
 	return res, nil
 }
+
+// TODO: move this into the symbolizer package when available
+func HasUnsymbolizedProfiles(symbols *symdb.Symbols) bool {
+	locations := symbols.Locations
+	mappings := symbols.Mappings
+	for _, loc := range locations {
+		if loc.MappingId == 0 || int(loc.MappingId) >= len(mappings) ||
+			!mappings[loc.MappingId].HasFunctions {
+			return true
+		}
+	}
+	return false
+}

pkg/experiment/ingester/segment.go

@@ -332,8 +332,8 @@ func concatSegmentHead(f *headFlush, w *writerOffset, s *metadata.StringTable) *
 		lb.WithLabelSet(model.LabelNameServiceName, f.head.key.service, model.LabelNameProfileType, profileType)
 	}
 
-	if f.flushed.HasNativeUnsymbolizedProfiles {
-		lb.WithLabelSet(model.LabelNameServiceName, f.head.key.service, metadata.LabelNameHasNativeUnsymbolizedProfiles, "true")
+	if f.flushed.HasUnsymbolizedProfiles {
+		lb.WithLabelSet(model.LabelNameServiceName, f.head.key.service, metadata.LabelNameUnsymbolized, "true")
 	}
 
 	// Other optional labels: