Skip to content

Commit f5c7ba4

Browse files
marcsanmimarcsanmi
authored
chore(deps): bump dskit to emit trace_id pprof label (#5261)
1 parent 3fca37a commit f5c7ba4

7 files changed

Lines changed: 56 additions & 35 deletions

File tree

‎cmd/pyroscope/help-all.txt.tmpl‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -429,6 +429,8 @@ Usage of ./pyroscope:
429429
The cluster label is an optional string to include in outbound packets and gossip streams. Other members in the memberlist cluster will discard any message whose label doesn't match the configured one, unless the 'cluster-label-verification-disabled' configuration option is set to true.
430430
-memberlist.cluster-label-verification-disabled
431431
When true, memberlist doesn't verify that inbound packets and gossip streams have the cluster label matching the configured one. This verification should be disabled while rolling out the change to the configured cluster label in a live memberlist cluster.
432+
-memberlist.compression-algorithm string
433+
Compression algorithm used for outgoing messages when -memberlist.compression-enabled is true. Supported values: lzw, snappy. Ignored when -memberlist.compression-enabled is false. (default "lzw")
432434
-memberlist.compression-enabled
433435
Enable message compression. This can be used to reduce bandwidth usage at the cost of slightly more CPU utilization. (default true)
434436
-memberlist.dead-node-reclaim-time duration
@@ -465,6 +467,8 @@ Usage of ./pyroscope:
465467
Timeout used when connecting to other nodes to send packet. (default 2s)
466468
-memberlist.packet-write-timeout duration
467469
Timeout for writing 'packet' data. (default 5s)
470+
-memberlist.processed-messages-queue-size int
471+
Size of the per-key internal queue for processing messages received from other nodes. Increasing this value may help to avoid dropping per-key updates when the node is processing many updates for the same key. (default 1024)
468472
-memberlist.propagation-delay-tracker.beacon-interval duration
469473
[experimental] How often to publish beacons for propagation tracking. (default 1m0s)
470474
-memberlist.propagation-delay-tracker.beacon-lifetime duration
@@ -1047,6 +1051,8 @@ Usage of ./pyroscope:
10471051
Comma separated list of yaml files or URLs with the configuration that can be updated at runtime. Runtime config files will be merged from left to right.
10481052
-runtime-config.http-client-cluster-validation.label string
10491053
[experimental] Primary cluster validation label.
1054+
-runtime-config.http-client-disable-keep-alives
1055+
Disable HTTP keep-alives for the runtime config HTTP client. When enabled, each reload opens a new connection, which prevents long-lived connections from being pinned to a single backend when the runtime config URL is served by multiple replicas behind a connection-level (L4) load balancer, such as a Kubernetes Service. (default true)
10501056
-runtime-config.http-client-timeout duration
10511057
HTTP client timeout when fetching runtime config from URLs. (default 30s)
10521058
-runtime-config.reload-period duration

‎docs/sources/configure-server/reference-configuration-parameters/index.md‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,14 @@ runtime_config:
168168
# CLI flag: -runtime-config.http-client-cluster-validation.label
169169
[label: <string> | default = ""]
170170

171+
# (advanced) Disable HTTP keep-alives for the runtime config HTTP client. When
172+
# enabled, each reload opens a new connection, which prevents long-lived
173+
# connections from being pinned to a single backend when the runtime config
174+
# URL is served by multiple replicas behind a connection-level (L4) load
175+
# balancer, such as a Kubernetes Service.
176+
# CLI flag: -runtime-config.http-client-disable-keep-alives
177+
[http_client_disable_keep_alives: <boolean> | default = true]
178+
171179
# The compaction_worker block configures the compaction-worker (V2).
172180
[compaction_worker: <compaction_worker>]
173181

@@ -2807,6 +2815,18 @@ The `memberlist` block configures the Gossip memberlist.
28072815
# CLI flag: -memberlist.received-messages-queue-size
28082816
[received_messages_queue_size: <int> | default = 1024]
28092817
2818+
# (advanced) Size of the per-key internal queue for processing messages received
2819+
# from other nodes. Increasing this value may help to avoid dropping per-key
2820+
# updates when the node is processing many updates for the same key.
2821+
# CLI flag: -memberlist.processed-messages-queue-size
2822+
[processed_messages_queue_size: <int> | default = 1024]
2823+
2824+
# (advanced) Compression algorithm used for outgoing messages when
2825+
# -memberlist.compression-enabled is true. Supported values: lzw, snappy.
2826+
# Ignored when -memberlist.compression-enabled is false.
2827+
# CLI flag: -memberlist.compression-algorithm
2828+
[compression_algorithm: <string> | default = "lzw"]
2829+
28102830
# Gossip address to advertise to other members in the cluster. Used for NAT
28112831
# traversal.
28122832
# CLI flag: -memberlist.advertise-addr

‎go.mod‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ require (
3030
github.com/google/uuid v1.6.0
3131
github.com/gorilla/mux v1.8.1
3232
github.com/grafana/alloy/syntax v0.1.0
33-
github.com/grafana/dskit v0.0.0-20260505171221-7f6e6a43e255
33+
github.com/grafana/dskit v0.0.0-20260616135346-e96eda8260cd
3434
github.com/grafana/pyroscope-go v1.2.8
3535
github.com/grafana/pyroscope-go/godeltaprof v0.1.11
3636
github.com/grafana/pyroscope-go/x/k6 v0.0.0-20241003203156-a917cea171d3
@@ -64,7 +64,7 @@ require (
6464
github.com/valyala/bytebufferpool v1.0.0
6565
github.com/xlab/treeprint v1.2.0
6666
go.etcd.io/bbolt v1.4.3
67-
go.opentelemetry.io/otel v1.43.0
67+
go.opentelemetry.io/otel v1.44.0
6868
go.opentelemetry.io/proto/otlp v1.10.0
6969
go.opentelemetry.io/proto/otlp/collector/profiles/v1development v0.3.0
7070
go.opentelemetry.io/proto/otlp/profiles/v1development v0.3.0
@@ -219,7 +219,7 @@ require (
219219
github.com/googleapis/enterprise-certificate-proxy v0.3.14 // indirect
220220
github.com/googleapis/gax-go/v2 v2.18.0 // indirect
221221
github.com/grafana/jfr-parser v0.17.1
222-
github.com/grafana/otel-profiling-go v0.5.1
222+
github.com/grafana/otel-profiling-go v0.6.0
223223
github.com/hashicorp/consul/api v1.33.7 // indirect
224224
github.com/hashicorp/errwrap v1.1.0 // indirect
225225
github.com/hashicorp/go-cleanhttp v0.5.2 // indirect
@@ -321,11 +321,11 @@ require (
321321
go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v1.43.0 // indirect
322322
go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.43.0 // indirect
323323
go.opentelemetry.io/otel/log v0.19.0 // indirect
324-
go.opentelemetry.io/otel/metric v1.43.0 // indirect
325-
go.opentelemetry.io/otel/sdk v1.43.0
324+
go.opentelemetry.io/otel/metric v1.44.0 // indirect
325+
go.opentelemetry.io/otel/sdk v1.44.0
326326
go.opentelemetry.io/otel/sdk/log v0.19.0 // indirect
327-
go.opentelemetry.io/otel/sdk/metric v1.43.0 // indirect
328-
go.opentelemetry.io/otel/trace v1.43.0
327+
go.opentelemetry.io/otel/sdk/metric v1.44.0 // indirect
328+
go.opentelemetry.io/otel/trace v1.44.0
329329
go.uber.org/multierr v1.11.0 // indirect
330330
go.uber.org/zap v1.27.1 // indirect
331331
golang.org/x/crypto v0.52.0 // indirect
@@ -346,7 +346,7 @@ replace (
346346

347347
// Replace memberlist with our fork which includes some fixes that haven't been
348348
// merged upstream yet.
349-
github.com/hashicorp/memberlist => github.com/grafana/memberlist v0.0.0-20260410132335-4887d8e8d493
349+
github.com/hashicorp/memberlist => github.com/grafana/memberlist v0.3.1-0.20260515134459-1798cf41aca7
350350

351351
// gopkg.in/yaml.v3
352352
// + https://github.com/go-yaml/yaml/pull/691

‎go.sum‎

Lines changed: 18 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,6 @@ github.com/go-logfmt/logfmt v0.5.0/go.mod h1:wCYkCAKZfumFQihp8CzCvQ3paCTfi41vtzG
267267
github.com/go-logfmt/logfmt v0.6.0 h1:wGYYu3uicYdqXVgoYbvnkrPVXkuLM1p1ifugDMEdRi4=
268268
github.com/go-logfmt/logfmt v0.6.0/go.mod h1:WYhtIu8zTZfxdn5+rREduYbwxfcBr/Vr6KEVveWlfTs=
269269
github.com/go-logr/logr v1.2.2/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
270-
github.com/go-logr/logr v1.3.0/go.mod h1:9T104GzyrTigFIr8wt5mBrctHMim0Nb2HLGrmQ40KvY=
271270
github.com/go-logr/logr v1.4.3 h1:CjnDlHq8ikf6E492q6eKboGOC0T8CDaOvkHCIg8idEI=
272271
github.com/go-logr/logr v1.4.3/go.mod h1:9T104GzyrTigFIr8wt5mBrctHMim0Nb2HLGrmQ40KvY=
273272
github.com/go-logr/stdr v1.2.2 h1:hSWxHoqTgW2S2qGc0LTAI563KZ5YKYRhT3MFKZMbjag=
@@ -408,14 +407,14 @@ github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674 h1:JeSE6pjso5T
408407
github.com/gorilla/websocket v1.5.4-0.20250319132907-e064f32e3674/go.mod h1:r4w70xmWCQKmi1ONH4KIaBptdivuRPyosB9RmPlGEwA=
409408
github.com/grafana/alloy/syntax v0.1.0 h1:+1xQakvQPH6N0y9+q2Fu5QePyzrve6i1wMNuXdWd1rQ=
410409
github.com/grafana/alloy/syntax v0.1.0/go.mod h1:8H9ToCc1M8F6A+je4rIH6saIe1MUCmjSk+Uje+LNLEo=
411-
github.com/grafana/dskit v0.0.0-20260505171221-7f6e6a43e255 h1:ZQ5ziUUTe+i4v5PccDzvRsrVCayCzp79Etbs8KvPh/s=
412-
github.com/grafana/dskit v0.0.0-20260505171221-7f6e6a43e255/go.mod h1:6zFIzal2FCd0JC1pE0ZTb2ftC0Jr/zsQR4zRNRdDfZA=
410+
github.com/grafana/dskit v0.0.0-20260616135346-e96eda8260cd h1:0nhpm/ZeGIeJ25fsYpYo7DeMIYxf7iObMxUdPPAEfu0=
411+
github.com/grafana/dskit v0.0.0-20260616135346-e96eda8260cd/go.mod h1:T0r0vLv/JwmOoSc/EOZw/5ni7r/djCoCdJ3/JnHDAjQ=
413412
github.com/grafana/jfr-parser v0.17.1 h1:dTECCXL+B9V6qu5x4msSKE9/FJPKeK0jrwLa5fkpkCA=
414413
github.com/grafana/jfr-parser v0.17.1/go.mod h1:+4zCC+tEWot6oQWjC72bG9TDDBiiiawMprp4EM1BioU=
415-
github.com/grafana/memberlist v0.0.0-20260410132335-4887d8e8d493 h1:gck0LSDVJ0k5l+G5/wYmJx2GlugUhZ7BaE4F95XuK/o=
416-
github.com/grafana/memberlist v0.0.0-20260410132335-4887d8e8d493/go.mod h1:h60o12SZn/ua/j0B6iKAZezA4eDaGsIuPO70eOaJ6WE=
417-
github.com/grafana/otel-profiling-go v0.5.1 h1:stVPKAFZSa7eGiqbYuG25VcqYksR6iWvF3YH66t4qL8=
418-
github.com/grafana/otel-profiling-go v0.5.1/go.mod h1:ftN/t5A/4gQI19/8MoWurBEtC6gFw8Dns1sJZ9W4Tls=
414+
github.com/grafana/memberlist v0.3.1-0.20260515134459-1798cf41aca7 h1:F5hMoc+tCK4AeUKfaL1XFEVEPSg+eKQe712fsSO/JA0=
415+
github.com/grafana/memberlist v0.3.1-0.20260515134459-1798cf41aca7/go.mod h1:OSu8+LHxPUHB67c9v5Gfw5NQZxFWOL3EKmn9TgHvyCo=
416+
github.com/grafana/otel-profiling-go v0.6.0 h1:W7lOZaJj4IJISXMcM1UBk3fJF3tzF2OD6MJBJaQp1H8=
417+
github.com/grafana/otel-profiling-go v0.6.0/go.mod h1:cqLIDgNXlnzknJ0WLiEe+JPjZk2MZ4ftMdqRJRWj1ZM=
419418
github.com/grafana/pyroscope-go v1.2.8 h1:UvCwIhlx9DeV7F6TW/z8q1Mi4PIm3vuUJ2ZlCEvmA4M=
420419
github.com/grafana/pyroscope-go v1.2.8/go.mod h1:SSi59eQ1/zmKoY/BKwa5rSFsJaq+242Bcrr4wPix1g8=
421420
github.com/grafana/pyroscope-go/godeltaprof v0.1.11 h1:el5LYpXissAiCKZ5/6yjlr6mhYVV6Cp5lahTocxraXM=
@@ -857,9 +856,8 @@ go.opentelemetry.io/contrib/propagators/jaeger v1.42.0 h1:jP8unWI6q5kcb3gpGLjKDG
857856
go.opentelemetry.io/contrib/propagators/jaeger v1.42.0/go.mod h1:xd89e/pUyPatUP1C4z1UknD9jHptESO99tWyvd4mWD4=
858857
go.opentelemetry.io/contrib/samplers/jaegerremote v0.36.0 h1:h8kHGv9+VIiJbQ2Qx6BbORZwcvVnd0le/SFK8Vom0bA=
859858
go.opentelemetry.io/contrib/samplers/jaegerremote v0.36.0/go.mod h1:tjrgaYHDx+1CmTk5YzNAUCbLX1ZrjrsogXBQHaVf7rI=
860-
go.opentelemetry.io/otel v1.21.0/go.mod h1:QZzNPQPm1zLX4gZK4cMi+71eaorMSGT3A4znnUvNNEo=
861-
go.opentelemetry.io/otel v1.43.0 h1:mYIM03dnh5zfN7HautFE4ieIig9amkNANT+xcVxAj9I=
862-
go.opentelemetry.io/otel v1.43.0/go.mod h1:JuG+u74mvjvcm8vj8pI5XiHy1zDeoCS2LB1spIq7Ay0=
859+
go.opentelemetry.io/otel v1.44.0 h1:JjwHmHpA4iZ3wBxluu2fbbE7j4kqlE8jXyAyPXH7HqU=
860+
go.opentelemetry.io/otel v1.44.0/go.mod h1:BMgjTHL9WPRlRjL2oZCBTL4whCGtXch2H4BhOPIAyYc=
863861
go.opentelemetry.io/otel/exporters/jaeger v1.17.0 h1:D7UpUy2Xc2wsi1Ras6V40q806WM07rqoCWzXu7Sqy+4=
864862
go.opentelemetry.io/otel/exporters/jaeger v1.17.0/go.mod h1:nPCqOnEH9rNLKqH/+rrUjiMzHJdV1BlpKcTwRTyKkKI=
865863
go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc v0.19.0 h1:Dn8rkudDzY6KV9dr/D/bTUuWgqDf9xe0rr4G2elrn0Y=
@@ -886,21 +884,20 @@ go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.43.0 h1:mS47AX77OtFfKG4
886884
go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.43.0/go.mod h1:PJnsC41lAGncJlPUniSwM81gc80GkgWJWr3cu2nKEtU=
887885
go.opentelemetry.io/otel/log v0.19.0 h1:KUZs/GOsw79TBBMfDWsXS+KZ4g2Ckzksd1ymzsIEbo4=
888886
go.opentelemetry.io/otel/log v0.19.0/go.mod h1:5DQYeGmxVIr4n0/BcJvF4upsraHjg6vudJJpnkL6Ipk=
889-
go.opentelemetry.io/otel/metric v1.21.0/go.mod h1:o1p3CA8nNHW8j5yuQLdc1eeqEaPfzug24uvsyIEJRWM=
890-
go.opentelemetry.io/otel/metric v1.43.0 h1:d7638QeInOnuwOONPp4JAOGfbCEpYb+K6DVWvdxGzgM=
891-
go.opentelemetry.io/otel/metric v1.43.0/go.mod h1:RDnPtIxvqlgO8GRW18W6Z/4P462ldprJtfxHxyKd2PY=
892-
go.opentelemetry.io/otel/sdk v1.21.0/go.mod h1:Nna6Yv7PWTdgJHVRD9hIYywQBRx7pbox6nwBnZIxl/E=
893-
go.opentelemetry.io/otel/sdk v1.43.0 h1:pi5mE86i5rTeLXqoF/hhiBtUNcrAGHLKQdhg4h4V9Dg=
894-
go.opentelemetry.io/otel/sdk v1.43.0/go.mod h1:P+IkVU3iWukmiit/Yf9AWvpyRDlUeBaRg6Y+C58QHzg=
887+
go.opentelemetry.io/otel/metric v1.44.0 h1:1w0gILTcHdr3YI+ixLyjemwrVnsMURbTZFrSYCdDdmc=
888+
go.opentelemetry.io/otel/metric v1.44.0/go.mod h1:8O7hanEPBNgEMmybD3s2VBKcgWOCsA6tzHBPODAiquo=
889+
go.opentelemetry.io/otel/metric/x v0.66.0 h1:YkCrx1zLOChi9ZcZ6euupOcsgzbVlec7D/xoEU1+cTA=
890+
go.opentelemetry.io/otel/metric/x v0.66.0/go.mod h1:d1+BDj9t96do0/1LoU1ayfCv79ZgNE41qbhBvnMOBZk=
891+
go.opentelemetry.io/otel/sdk v1.44.0 h1:nHYwb9lK+fJPU/dnT6s7W7Z8itMWyqrnVfbheVYrZ58=
892+
go.opentelemetry.io/otel/sdk v1.44.0/go.mod h1:Osuydd3Se74nqjAKxid74N5eC+jfEqfTegHRnq58oK0=
895893
go.opentelemetry.io/otel/sdk/log v0.19.0 h1:scYVLqT22D2gqXItnWiocLUKGH9yvkkeql5dBDiXyko=
896894
go.opentelemetry.io/otel/sdk/log v0.19.0/go.mod h1:vFBowwXGLlW9AvpuF7bMgnNI95LiW10szrOdvzBHlAg=
897895
go.opentelemetry.io/otel/sdk/log/logtest v0.19.0 h1:BEbF7ZBB6qQloV/Ub1+3NQoOUnVtcGkU3XX4Ws3GQfk=
898896
go.opentelemetry.io/otel/sdk/log/logtest v0.19.0/go.mod h1:Lua81/3yM0wOmoHTokLj9y9ADeA02v1naRrVrkAZuKk=
899-
go.opentelemetry.io/otel/sdk/metric v1.43.0 h1:S88dyqXjJkuBNLeMcVPRFXpRw2fuwdvfCGLEo89fDkw=
900-
go.opentelemetry.io/otel/sdk/metric v1.43.0/go.mod h1:C/RJtwSEJ5hzTiUz5pXF1kILHStzb9zFlIEe85bhj6A=
901-
go.opentelemetry.io/otel/trace v1.21.0/go.mod h1:LGbsEB0f9LGjN+OZaQQ26sohbOmiMR+BaslueVtS/qQ=
902-
go.opentelemetry.io/otel/trace v1.43.0 h1:BkNrHpup+4k4w+ZZ86CZoHHEkohws8AY+WTX09nk+3A=
903-
go.opentelemetry.io/otel/trace v1.43.0/go.mod h1:/QJhyVBUUswCphDVxq+8mld+AvhXZLhe+8WVFxiFff0=
897+
go.opentelemetry.io/otel/sdk/metric v1.44.0 h1:3LlKgI+VjbVsjNRFZJZAJ30WjXC5VkNRks6si09iEfI=
898+
go.opentelemetry.io/otel/sdk/metric v1.44.0/go.mod h1:5B5pMARnXxKhltooO4xUuCBorl65a4EpnTalObqOigA=
899+
go.opentelemetry.io/otel/trace v1.44.0 h1:jxF5CsGYCe74MCRx2X4g7WsY/VBKRqqpNvXlX/6gtIk=
900+
go.opentelemetry.io/otel/trace v1.44.0/go.mod h1:oLl1jrMQAVo6v3GAggN+1VH9VIz9iUSvW53sW1Q8PIE=
904901
go.opentelemetry.io/proto/otlp v1.10.0 h1:IQRWgT5srOCYfiWnpqUYz9CVmbO8bFmKcwYxpuCSL2g=
905902
go.opentelemetry.io/proto/otlp v1.10.0/go.mod h1:/CV4QoCR/S9yaPj8utp3lvQPoqMtxXdzn7ozvvozVqk=
906903
go.opentelemetry.io/proto/otlp/collector/profiles/v1development v0.3.0 h1:AWBLtJn3ajH399gyOuJdqPsC9w152x3xGVVO/UK3vyM=
@@ -1034,7 +1031,6 @@ golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
10341031
golang.org/x/sys v0.8.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
10351032
golang.org/x/sys v0.10.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
10361033
golang.org/x/sys v0.12.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
1037-
golang.org/x/sys v0.14.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
10381034
golang.org/x/sys v0.17.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
10391035
golang.org/x/sys v0.20.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
10401036
golang.org/x/sys v0.28.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=

‎pkg/metastore/discovery/parse.go‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,11 @@ import (
1414

1515
func NewDiscovery(l log.Logger, address string, reg prometheus.Registerer) (Discovery, error) {
1616
if strings.HasPrefix(address, "dnssrvnoa+") {
17-
p := dns.NewProvider(l,
17+
p := dns.NewProvider(dns.MiekgdnsResolverType, 2, l,
1818
prometheus.WrapRegistererWithPrefix(
1919
"pyroscope_metastore_client_",
2020
reg,
21-
),
22-
dns.MiekgdnsResolverType)
21+
))
2322
return NewDNSDiscovery(l, address, p), nil
2423
}
2524
if strings.HasPrefix(address, "kubernetes:///") {

‎pkg/metastore/raftnode/node_bootstrap.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func (n *Node) bootstrap() error {
4343
}
4444

4545
func (n *Node) bootstrapPeersWithRetries() (peers []raft.Server, err error) {
46-
prov := dns.NewProvider(n.logger, n.reg, dns.MiekgdnsResolverType)
46+
prov := dns.NewProvider(dns.MiekgdnsResolverType, 2, n.logger, n.reg)
4747
attempt := func() bool {
4848
peers, err = n.bootstrapPeers(prov)
4949
level.Debug(n.logger).Log("msg", "resolving bootstrap peers", "peers", fmt.Sprint(peers), "err", err)

‎pkg/pyroscope/modules.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ func (f *Pyroscope) initMemberlistKV() (services.Service, error) {
352352
f.reg,
353353
),
354354
)
355-
dnsProvider := dns.NewProvider(f.logger, dnsProviderReg, dns.GolangResolverType)
355+
dnsProvider := dns.NewProvider(dns.GolangResolverType, 2, f.logger, dnsProviderReg)
356356

357357
f.Cfg.MemberlistKV.MetricsNamespace = "pyroscope"
358358
f.MemberlistKV = memberlist.NewKVInitService(&f.Cfg.MemberlistKV, f.logger, dnsProvider, f.reg)

0 commit comments

Comments
 (0)