Fix cloud-run-locally input behaviour and action failing without flags

- Fixes the behaviour of `cloud-run-locally` action input where it was
behaving opposite to what was expected
- Fixes a bug where if no flags are sent as input the action crashes with
error code 255

Fixes #15
Fixed #14

Author: DefCon-007

.github/workflows/test.yaml

@@ -22,6 +22,19 @@ jobs:
         flags: --vus 10 --duration 30s
         parallel: true
         cloud-run-locally: false
+  protocol-without-flags:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - name: Setup Grafana k6
+      uses: grafana/setup-k6-action@main
+      with:
+        k6-version: '0.49.0'
+    - uses: ./
+      continue-on-error: true
+      with:
+        path: |
+          ./dev/protocol*.js
   verify-scripts:
     runs-on: ubuntu-latest
     env:

action.yaml

@@ -24,12 +24,13 @@ inputs:
     required: false
   cloud-run-locally:
     description: 'If true, run tests locally instead and upload results to Grafana Cloud k6'
+    default: "true"
     required: false
   cloud-comment-on-pr:
     description: 'If true, comment the cloud test run URL on the pull request'
     default: "true"
     required: false
-  only-verify-scripts: 
+  only-verify-scripts:
     description: 'If true, only check if the test scripts are valid and skip test execution'
     default: "false"
     required: false

dist/index.js

@@ -34466,16 +34466,33 @@ async function run() {
             process.exit(1);
         }
         function generateCommand(path) {
+            let command;
             const args = [
                 // `--address=""`, // Disable the REST API. THIS DOESN'T WORK???? TODO: Investigate
                 ...(flags ? flags.split(' ') : []),
             ];
-            if (isCloud && cloudRunLocally) {
-                return `k6 cloud ${args.join(' ')} ${path}`;
+            if (isCloud) {
+                // Cloud execution is possible for the test
+                if (cloudRunLocally) {
+                    // Execute tests locally and upload results to cloud
+                    command = "k6 run";
+                    args.push(`--out=cloud`);
+                }
+                else {
+                    // Execute tests in cloud
+                    command = "k6 cloud";
+                }
             }
             else {
-                return `k6 run ${args.join(' ')}${(isCloud) ? [' --out=cloud'] : []} ${path}`;
+                // Local execution
+                command = "k6 run";
             }
+            // Add path the arguments list
+            args.push(path);
+            // Append arguments to the command
+            command = `${command} ${args.join(' ')}`;
+            core.debug("🤖 Generated command: " + command);
+            return command;
         }
         function runCommand(command) {
             const parts = command.split(' ');
@@ -34487,7 +34504,7 @@ async function run() {
                 detached: true,
                 env: process.env,
             });
-            // Parse k6 command output and extract test run URLs if running in cloud mode. 
+            // Parse k6 command output and extract test run URLs if running in cloud mode.
             // Also, print the output to the console, excluding the progress lines.
             child.stdout?.on('data', (data) => (0, k6OutputParser_1.parseK6Output)(data, TEST_RESULT_URLS_MAP, TOTAL_TEST_RUNS));
             return child;

src/index.ts

@@ -138,15 +138,35 @@ export async function run(): Promise<void> {
         }
 
         function generateCommand(path: string): string {
+            let command;
             const args = [
                 // `--address=""`, // Disable the REST API. THIS DOESN'T WORK???? TODO: Investigate
                 ...(flags ? flags.split(' ') : []),
             ]
-            if (isCloud && cloudRunLocally) {
-                return `k6 cloud ${args.join(' ')} ${path}`
+
+            if (isCloud) {
+                // Cloud execution is possible for the test
+                if (cloudRunLocally) {
+                    // Execute tests locally and upload results to cloud
+                    command = "k6 run"
+                    args.push(`--out=cloud`)
+                } else {
+                    // Execute tests in cloud
+                    command = "k6 cloud"
+                }
             } else {
-                return `k6 run ${args.join(' ')}${(isCloud) ? [' --out=cloud'] : []} ${path}`
+                // Local execution
+                command = "k6 run"
             }
+
+            // Add path the arguments list
+            args.push(path)
+
+            // Append arguments to the command
+            command = `${command} ${args.join(' ')}`
+
+            core.debug("🤖 Generated command: " + command);
+            return command;
         }
 
         function runCommand(command: string): any {
@@ -160,7 +180,7 @@ export async function run(): Promise<void> {
                 detached: true,
                 env: process.env,
             });
-            // Parse k6 command output and extract test run URLs if running in cloud mode. 
+            // Parse k6 command output and extract test run URLs if running in cloud mode.
             // Also, print the output to the console, excluding the progress lines.
             child.stdout?.on('data', (data) => parseK6Output(data, TEST_RESULT_URLS_MAP, TOTAL_TEST_RUNS));