SceneDataTransformer: Correctly resolve isDataReadyToDisplay (#194)

dprokop · web-flow · commit 541d9d4b4b0f · 2023-05-18T11:31:43.000-06:00
diff --git a/packages/scenes/src/querying/SceneDataTransformer.ts b/packages/scenes/src/querying/SceneDataTransformer.ts
@@ -75,10 +75,12 @@ export class SceneDataTransformer extends SceneObjectBase<SceneDataTransformerSt
   }
 
   public isDataReadyToDisplay() {
-    if (this.state.$data && this.state.$data.isDataReadyToDisplay) {
-      return this.state.$data.isDataReadyToDisplay();
+    const dataObject = this.getSourceData();
+    if (dataObject.isDataReadyToDisplay) {
+      return dataObject.isDataReadyToDisplay();
     }
-    return false;
+
+    return true;
   }
 
   public reprocessTransformations() {

Original file line number	Diff line number	Diff line change
`@@ -75,10 +75,12 @@ export class SceneDataTransformer extends SceneObjectBase<SceneDataTransformerSt`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`public isDataReadyToDisplay() {`
`78`		`- if (this.state.$data && this.state.$data.isDataReadyToDisplay) {`
`79`		`- return this.state.$data.isDataReadyToDisplay();`
	`78`	`+ const dataObject = this.getSourceData();`
	`79`	`+ if (dataObject.isDataReadyToDisplay) {`
	`80`	`+ return dataObject.isDataReadyToDisplay();`
`80`	`81`	`}`
`81`		`- return false;`
	`82`	`+`
	`83`	`+ return true;`
`82`	`84`	`}`
`83`	`85`
`84`	`86`	`public reprocessTransformations() {`