Merge branch 'main' of github.com:grafana/scenes into scene-variable-set-detect-changes

Author: torkelo

.github/workflows/build-and-test.yml

@@ -20,8 +20,11 @@ jobs:
       - name: Install dependencies
         run: yarn
 
-      - name: Build library
-        run: lerna run build
-
       - name: Test library
         run: lerna run test
+
+      - name: Typecheck library
+        run: lerna run typecheck
+
+      - name: Build library
+        run: lerna run build

package.json

@@ -43,4 +43,4 @@
     "lerna": "^6.5.1",
     "lint-staged": "^13.2.0"
   }
-}
+}

packages/scenes/package.json

@@ -95,6 +95,7 @@
     "rollup": "2.79.1",
     "rollup-plugin-dts": "^5.0.0",
     "rollup-plugin-esbuild": "5.0.0",
+    "rollup-plugin-fork-ts-checker": "^0.0.6",
     "rollup-plugin-node-externals": "^5.0.0",
     "rollup-plugin-svg-import": "^1.6.0",
     "rxjs": "7.8.0",

packages/scenes/rollup.config.ts

@@ -4,19 +4,21 @@ import dts from 'rollup-plugin-dts';
 import esbuild from 'rollup-plugin-esbuild';
 import eslint from '@rollup/plugin-eslint';
 import { externals } from 'rollup-plugin-node-externals';
-
+import ftc from 'rollup-plugin-fork-ts-checker';
 const env = process.env.NODE_ENV || 'production';
 const pkg = require('./package.json');
 
+const plugins = [
+  externals({ deps: true, devDeps: true, packagePath: './package.json' }),
+  resolve({ browser: true }),
+  esbuild(),
+  eslint(),
+];
+
 export default [
   {
     input: 'src/index.ts',
-    plugins: [
-      externals({ deps: true, devDeps: true, packagePath: './package.json' }),
-      resolve({ browser: true }),
-      esbuild(),
-      eslint(),
-    ],
+    plugins: env === 'development' ? [ftc(), ...plugins] : plugins,
     output: [
       {
         format: 'cjs',

packages/scenes/src/querying/SceneDataTransformer.test.ts

@@ -76,11 +76,8 @@ const runRequestMock = jest.fn().mockReturnValue(
   })
 );
 
-let sentRequest: DataQueryRequest | undefined;
-
 jest.mock('@grafana/runtime', () => ({
   getRunRequest: () => (ds: DataSourceApi, request: DataQueryRequest) => {
-    sentRequest = request;
     return runRequestMock(ds, request);
   },
   getDataSourceSrv: () => {

packages/scenes/src/querying/SceneQueryRunner.test.ts

@@ -1,7 +1,6 @@
-import { map, Observable, of } from 'rxjs';
+import { of } from 'rxjs';
 
 import {
-  ArrayVector,
   DataQueryRequest,
   DataSourceApi,
   getDefaultTimeRange,

tsconfig.json

@@ -4,14 +4,21 @@
     "declarationDir": "./compiled",
     "emitDeclarationOnly": true,
     "isolatedModules": true,
-    "rootDirs": ["."]
+    "rootDirs": [
+      "."
+    ]
   },
-  "exclude": ["dist/**/*"],
-  "include": ["utils/**/*.ts*", "src/**/*.ts*"],
+  "exclude": [
+    "dist/**/*"
+  ],
+  "include": [
+    "utils/**/*.ts*",
+    "src/**/*.ts*"
+  ],
   "ts-node": {
     "compilerOptions": {
       "isolatedModules": false,
       "module": "commonjs"
     }
   }
-}
+}