groupBy variable update logic cleaup (#1380)

Author: kristinademeshchik

packages/scenes/src/variables/groupby/GroupByVariable.test.tsx

@@ -301,64 +301,6 @@ describe.each(['11.1.2', '11.1.1'])('GroupByVariable', (v) => {
       expect(variable.state.value).toEqual(['defaultVal1', 'defaultVal2']);
     });
 
-    it('should apply defaultValue to value when defaultValue is set', async () => {
-      const { variable } = setupTest({});
-
-      expect(variable.state.value).toEqual('');
-
-      act(() => {
-        variable.setState({
-          defaultValue: {
-            value: ['newDefault'],
-            text: ['newDefault'],
-          },
-        });
-      });
-
-      expect(variable.state.value).toEqual(['newDefault']);
-      expect(variable.state.text).toEqual(['newDefault']);
-    });
-
-    it('should update value when defaultValue changes', async () => {
-      const { variable } = setupTest({
-        defaultValue: {
-          value: ['defaultVal1'],
-          text: ['defaultVal1'],
-        },
-      });
-
-      expect(variable.state.value).toEqual(['defaultVal1']);
-
-      act(() => {
-        variable.setState({
-          defaultValue: {
-            value: ['newDefault'],
-            text: ['newDefault'],
-          },
-        });
-      });
-
-      expect(variable.state.value).toEqual(['newDefault']);
-      expect(variable.state.text).toEqual(['newDefault']);
-    });
-
-    it('should reset value when defaultValue is cleared', async () => {
-      const { variable } = setupTest({
-        defaultValue: {
-          value: ['defaultVal1'],
-          text: ['defaultVal1'],
-        },
-      });
-
-      expect(variable.state.value).toEqual(['defaultVal1']);
-
-      act(() => {
-        variable.setState({ defaultValue: undefined });
-      });
-
-      expect(variable.state.value).toEqual([]);
-    });
-
     it('should work with browser history action on user action', () => {
       const { variable } = setupTest({
         defaultOptions: [

packages/scenes/src/variables/groupby/GroupByVariable.tsx

@@ -228,19 +228,7 @@ export class GroupByVariable extends MultiValueVariable<GroupByVariableState> {
       }
     }
 
-    const sub = this.subscribeToState((newState, prevState) => {
-      if (!isEqual(newState.defaultValue, prevState.defaultValue)) {
-        if (newState.defaultValue) {
-          this.changeValueTo(newState.defaultValue.value, newState.defaultValue.text, false);
-        } else {
-          this.changeValueTo([], [], false);
-        }
-      }
-    });
-
     return () => {
-      sub.unsubscribe();
-
       if (this.state.defaultValue) {
         this.restoreDefaultValues();
       }