Skip to content

Commit d648144

Browse files
fix(trufflehog): fail the org-required scan on verified secrets (#212)
Restore blocking for credentials TruffleHog confirmed with the issuer. Unverified findings stay comments-only. Test/example values can use trufflehog:ignore per the consumer docs.
1 parent 494b720 commit d648144

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/org-required-trufflehog.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ jobs:
2323
name: TruffleHog Secret Scan
2424
uses: grafana/security-github-actions/.github/workflows/reusable-trufflehog.yml@0380389a5fad89a566ff9c2eb6ccc402c629e69d # main
2525
with:
26-
# Non-blocking: job succeeds; PR still gets comments/artifacts when findings exist
27-
fail-on-verified: "false" # Set "true" to fail on verified secrets
28-
fail-on-unverified: "false" # Set "true" to fail on unverified secrets
26+
# Blocking: verified secrets fail the required workflow; unverified stay comments-only
27+
fail-on-verified: "true" # Block PRs with verified secrets
28+
fail-on-unverified: "false" # Don't block on unverified secrets
2929
runs-on: ${{ (!github.event.repository.private || github.repository_owner != 'grafana') && 'ubuntu-latest' || 'ubuntu-any-minus' }} # grafana private repos use self-hosted runners (any arch, medium or smaller); other orgs use ubuntu-latest
3030
secrets: inherit

0 commit comments

Comments
 (0)