Skip to content

Commit 5a1ba81

Browse files
authored
fix(release): remove changelog.disable to allow --release-notes to work (#2705)
## Summary - Remove `changelog.disable: true` from `.goreleaser.yml` because it suppresses `--release-notes` content, resulting in empty draft release bodies. `changelog.disable: true` skips the entire changelog pipe ([source](https://github.com/goreleaser/goreleaser/blob/main/internal/pipe/changelog/changelog.go#L45-L51)), which means `--release-notes` file loading never executes. Without `disable`, `--release-notes` still skips GoReleaser's own changelog generation via an early return ([source](https://github.com/goreleaser/goreleaser/blob/main/internal/pipe/changelog/changelog.go#L73-L74)), so only the git-cliff content is used.
1 parent 49bd3e0 commit 5a1ba81

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

.goreleaser.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,5 +74,4 @@ signs:
7474
release:
7575
# If you want to manually examine the release before it's live, uncomment this line:
7676
draft: true
77-
changelog:
78-
disable: true
77+

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,4 +142,4 @@ Currently there are a few manual steps to this:
142142

143143
The Action creates the release, but leaves it in "draft" state. Open it up in
144144
a [browser](https://github.com/grafana/terraform-provider-grafana/releases)
145-
and if all looks well, click the `Auto-generate release notes` button and mash the publish button.
145+
and if all looks well, publish the release. Release notes are generated automatically by git-cliff.

0 commit comments

Comments
 (0)