Skip to content

src/hatcogd/line.go Barely RFC2812 compliant. #15

@jgrar

Description

@jgrar

There are numerous issues with the ParseLine() function, eg.

  • No distinction is made between nick and user tokens in the prefix, you've simply called 'nick' 'user' and then not parsed the actual user token.
  • A nick prefix can exist without user and host tokens supplied as simply ":nick CMD etc"
  • The parser applies little to no restrictions on characters within tokens.

And various others. Although it may "appear to work" I suggest (re)reading http://tools.ietf.org/html/rfc2812#section-2.3.1 and implementing the grammar completely as this will break should a server decide to do anything "weird".

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions