Add dependabot config and update CI

Author: mangalaman93

.github/dependabot.yml

@@ -0,0 +1,14 @@
+version: 2
+updates:
+  - package-ecosystem: "gomod"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+    commit-message:
+      prefix: "deps"
+      include: "scope"
+
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"

.github/workflows/ci-go-tests.yml

@@ -0,0 +1,30 @@
+name: ci-go-tests
+
+on:
+  pull_request:
+    types:
+      - opened
+      - reopened
+      - synchronize
+      - ready_for_review
+    branches:
+      - main
+
+jobs:
+  ci-go-tests:
+    if: github.event.pull_request.draft == false
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Setup Go 1.23.x
+        uses: actions/setup-go@v5
+        with:
+          go-version: "1.23"
+          cache-dependency-path: go.sum
+
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v8.0.0
+
+      - name: Run Unit Tests
+        run: go test -race -v ./...

.github/workflows/golangci-lint.yml

@@ -0,0 +1,111 @@
+version: "2"
+linters:
+  default: none
+  enable:
+    - asasalint
+    - asciicheck
+    - bidichk
+    - bodyclose
+    - canonicalheader
+    - containedctx
+    - copyloopvar
+    - decorder
+    - dogsled
+    # - dupl
+    - dupword
+    - durationcheck
+    - errcheck
+    - errchkjson
+    - errname
+    - exhaustive
+    - exptostd
+    - fatcontext
+    - ginkgolinter
+    - gocheckcompilerdirectives
+    - gochecknoinits
+    - gochecksumtype
+    # - gocognit
+    - goconst
+    - gocritic
+    # - gocyclo
+    # - godot
+    - godox
+    - goheader
+    - gomoddirectives
+    - gomodguard
+    - goprintffuncname
+    # - gosec
+    - gosmopolitan
+    - govet
+    - grouper
+    - iface
+    - importas
+    - inamedparam
+    - ineffassign
+    - interfacebloat
+    - intrange
+    - ireturn
+    - lll
+    - loggercheck
+    # - maintidx
+    - makezero
+    - mirror
+    - misspell
+    - musttag
+    - nakedret
+    - nilerr
+    - nilnesserr
+    - nilnil
+    - nolintlint
+    - nonamedreturns
+    - nosprintfhostport
+    - paralleltest
+    - perfsprint
+    - prealloc
+    - predeclared
+    - promlinter
+    - protogetter
+    - reassign
+    - recvcheck
+    - revive
+    - rowserrcheck
+    - sloglint
+    - spancheck
+    - sqlclosecheck
+    - staticcheck
+    - tagalign
+    - testableexamples
+    - testifylint
+    - thelper
+    - tparallel
+    - unconvert
+    - unparam
+    - unused
+    - usestdlibvars
+    - usetesting
+    - wastedassign
+    - zerologlint
+  settings:
+    lll:
+      line-length: 120
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

.golangci.yaml

@@ -10,14 +10,18 @@ import (
 )
 
 func TestNewArenaNoDir(t *testing.T) {
+	t.Parallel()
+
 	aa, err := newArena(fmt.Sprintf("%d/temp.dat", time.Now().UnixNano()), 100)
 	if aa != nil || err == nil || os.IsExist(err) {
 		t.Fatalf("unexpected return for newArena :: %v", err)
 	}
 }
 
 func TestNewArenaNoReadPerm(t *testing.T) {
-	fileName := path.Join(os.TempDir(), "temp.dat")
+	t.Parallel()
+
+	fileName := path.Join(os.TempDir(), fmt.Sprintf("%d-temp.dat", time.Now().UnixNano()))
 	defer func() {
 		if err := os.Remove(fileName); err != nil {
 			t.Fatalf("error in deleting file: %v :: %v", fileName, err)
@@ -35,8 +39,10 @@ func TestNewArenaNoReadPerm(t *testing.T) {
 }
 
 func TestNewArenaNoFile(t *testing.T) {
+	t.Parallel()
+
 	arenaSize := 100
-	fileName := path.Join(os.TempDir(), "temp.dat")
+	fileName := path.Join(os.TempDir(), fmt.Sprintf("%d-temp.dat", time.Now().UnixNano()))
 	defer func() {
 		if err := os.Remove(fileName); err != nil {
 			t.Fatalf("error in deleting file: %v :: %v", fileName, err)
@@ -65,8 +71,10 @@ func TestNewArenaNoFile(t *testing.T) {
 }
 
 func TestNewArenaLargerFile(t *testing.T) {
+	t.Parallel()
+
 	arenaSize := 100
-	fileName := path.Join(os.TempDir(), "temp.dat")
+	fileName := path.Join(os.TempDir(), fmt.Sprintf("%d-temp.dat", time.Now().UnixNano()))
 	defer func() {
 		if err := os.Remove(fileName); err != nil {
 			t.Fatalf("error in deleting file: %v :: %v", fileName, err)
@@ -104,6 +112,8 @@ func TestNewArenaLargerFile(t *testing.T) {
 }
 
 func TestNewArenaNoFolder(t *testing.T) {
+	t.Parallel()
+
 	arenaSize := 100
 	aa, err := newArena("1/2/3/4/5/6/aa.dat", arenaSize)
 	if !os.IsNotExist(errors.Unwrap(err)) || aa != nil {

.travis.yml

@@ -15,13 +15,13 @@ const (
 
 // arenaManager manages all the arenas for a bigqueue
 type arenaManager struct {
-	dir       string
-	conf      *bqConfig
-	md        *metadata
-	baseAid   int
-	arenas    []*mmap.File
-	inMem     int
-	fullPath  []byte
+	dir      string
+	conf     *bqConfig
+	md       *metadata
+	baseAid  int
+	arenas   []*mmap.File
+	inMem    int
+	fullPath []byte
 }
 
 // newArenaManager returns a pointer to new arenaManager.

arena_test.go

@@ -51,6 +51,7 @@ func getBenchParams() []benchParam {
 }
 
 func createBenchDir(b *testing.B, dir string) {
+	b.Helper()
 	if _, err := os.Stat(dir); os.IsNotExist(err) {
 		if err := os.Mkdir(dir, 0744); err != nil {
 			b.Fatalf("unable to create dir for benchmark: %v", err)
@@ -59,6 +60,7 @@ func createBenchDir(b *testing.B, dir string) {
 }
 
 func removeBenchDir(b *testing.B, dir string) {
+	b.Helper()
 	if err := os.RemoveAll(dir); err != nil {
 		b.Fatalf("unable to delete dir for benchmark: %v", err)
 	}
@@ -72,10 +74,10 @@ func BenchmarkNewMmapQueue(b *testing.B) {
 		}
 		prevValue = param.arenaSize
 
-		b.Run(fmt.Sprintf("ArenaSize-%s", param.arenaSizeString), func(b *testing.B) {
+		b.Run(fmt.Sprintf("ArenaSize-%v", param.arenaSizeString), func(b *testing.B) {
 			b.ReportAllocs()
 			b.StopTimer()
-			for i := 0; i < b.N; i++ {
+			for range b.N {
 				dir := path.Join(os.TempDir(), "testdir")
 				createBenchDir(b, path.Join(os.TempDir(), "testdir"))
 
@@ -112,7 +114,7 @@ func BenchmarkEnqueue(b *testing.B) {
 
 			b.ReportAllocs()
 			b.ResetTimer()
-			for i := 0; i < b.N; i++ {
+			for range b.N {
 				if err := bq.Enqueue(param.message); err != nil {
 					b.Fatalf("unable to enqueue: %v", err)
 				}
@@ -144,7 +146,7 @@ func BenchmarkEnqueueString(b *testing.B) {
 			message := string(param.message)
 			b.ReportAllocs()
 			b.ResetTimer()
-			for i := 0; i < b.N; i++ {
+			for range b.N {
 				if err := bq.EnqueueString(message); err != nil {
 					b.Fatalf("unable to enqueue: %v", err)
 				}
@@ -173,15 +175,15 @@ func BenchmarkDequeue(b *testing.B) {
 				b.Fatalf("unable to create bigqueue: %v", err)
 			}
 
-			for i := 0; i < b.N; i++ {
+			for range b.N {
 				if err := bq.Enqueue(param.message); err != nil {
 					b.Fatalf("unable to enqueue: %v", err)
 				}
 			}
 
 			b.ReportAllocs()
 			b.ResetTimer()
-			for i := 0; i < b.N; i++ {
+			for range b.N {
 				if _, err := bq.Dequeue(); err != nil {
 					b.Fatalf("unable to dequeue: %v", err)
 				}
@@ -211,15 +213,15 @@ func BenchmarkDequeueString(b *testing.B) {
 			}
 
 			message := string(param.message)
-			for i := 0; i < b.N; i++ {
+			for range b.N {
 				if err := bq.EnqueueString(message); err != nil {
 					b.Fatalf("unable to enqueue: %v", err)
 				}
 			}
 
 			b.ReportAllocs()
 			b.ResetTimer()
-			for i := 0; i < b.N; i++ {
+			for range b.N {
 				if _, err := bq.DequeueString(); err != nil {
 					b.Fatalf("unable to dequeue: %v", err)
 				}
@@ -245,7 +247,7 @@ func BenchmarkStringDoubleCopy(b *testing.B) {
 	}
 
 	data := "abcdefghijk"
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		if err := bq.Enqueue([]byte(data)); err != nil {
 			b.Fatalf("error in enqueue :: %v", err)
 		}
@@ -263,7 +265,7 @@ func BenchmarkStringNoCopy(b *testing.B) {
 	}
 
 	data := "abcdefghijk"
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		if err := bq.EnqueueString(data); err != nil {
 			b.Fatalf("error in enqueue :: %v", err)
 		}

arenamanager.go

@@ -145,7 +145,7 @@ func (q *MmapQueue) Close() error {
 	// between periodic flush goroutine and Close() function.
 	// A possible lock cycle is here:
 	//        Close() after it has acquired the lock ->
-	//     -> Close() waiting for periodic flush goroutine to stop -> 
+	//     -> Close() waiting for periodic flush goroutine to stop ->
 	//     -> Periodic flush goroutine is trying to acquire the lock ->
 	//     -> Close() to release the lock
 	close(q.quit)
@@ -207,7 +207,7 @@ func (q *MmapQueue) periodicFlush() {
 
 	timer := &time.Timer{C: make(chan time.Time)}
 	if q.conf.flushPeriod > 0 {
-		timer = time.NewTimer(time.Duration(q.conf.flushPeriod))
+		timer = time.NewTimer(q.conf.flushPeriod)
 	}
 
 	var drainFlag bool
@@ -217,7 +217,7 @@ func (q *MmapQueue) periodicFlush() {
 				<-timer.C
 			}
 
-			timer.Reset(time.Duration(q.conf.flushPeriod))
+			timer.Reset(q.conf.flushPeriod)
 			drainFlag = false
 		}