Refactor OverlayPage and fix mouse pointer visibility

Co-authored-by: toniolo.luca <toniolo.luca@outlook.com>

Author: cursoragent

src/Captura/Pages/OverlayPage.xaml.cs

@@ -22,7 +22,7 @@ namespace Captura
 {
     public partial class OverlayPage
     {
-        public OverlayPage()
+        OverlayPage()
         {
             InitializeComponent();
 
@@ -37,24 +37,15 @@ public OverlayPage()
 
         void AddToGrid(LayerFrame Frame, bool CanResize)
         {
-            if (Grid == null)
-                return;
-
             Grid.Children.Add(Frame);
 
             Panel.SetZIndex(Frame, 0);
 
-            // Wait for visual tree to be ready before accessing AdornerLayer
-            Frame.Loaded += (s, e) =>
-            {
-                var layer = AdornerLayer.GetAdornerLayer(Frame);
-                if (layer != null)
-                {
-                    var adorner = new OverlayPositionAdorner(Frame, CanResize);
-                    layer.Add(adorner);
-                    adorner.PositionUpdated += Frame.RaisePositionChanged;
-                }
-            };
+            var layer = AdornerLayer.GetAdornerLayer(Frame);
+            var adorner = new OverlayPositionAdorner(Frame, CanResize);
+            layer.Add(adorner);
+
+            adorner.PositionUpdated += Frame.RaisePositionChanged;
         }
 
         LayerFrame Generate(PositionedOverlaySettings Settings, string Text, Color BackgroundColor)
@@ -387,7 +378,7 @@ bool IsOutsideGrid(Point Point)
 
         void UIElement_OnMouseMove(object Sender, MouseEventArgs E)
         {
-            if (ServiceProvider.Get<Settings>().MousePointerOverlay.DisplayHighlight)
+            if (ServiceProvider.Get<Settings>().MousePointerOverlay.Display)
                 MousePointer.Visibility = Visibility.Visible;
 
             var position = E.GetPosition(Grid);