Commit 5dced53
committed
fix(store): drop dead-condition re-check in EditWarningCheck across Product/Collection/Brand/Category/Blog
CodeQL flagged this pattern (in the Page consolidation PR): the inner
'x.LimitedToStores &&' re-check in the OR's second branch is always
true, since it's only reached once the first branch's !x.LimitedToStores
has already evaluated false. Same legacy idiom exists identically in
these five already-merged Store controllers; removing the dead
re-check does not change behavior.
- ProductController.EditWarningCheck
- CollectionController.EditWarningCheck
- BrandController.EditWarningCheck
- CategoryController.EditWarningCheck
- BlogController.EditWarningCheck
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FRztBQVfXimBPMFAioLabo1 parent 2da0b6b commit 5dced53
5 files changed
Lines changed: 5 additions & 10 deletions
File tree
- src/Web/Grand.Web.Store/Controllers
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
| 49 | + | |
51 | 50 | | |
52 | 51 | | |
53 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
| 41 | + | |
43 | 42 | | |
44 | 43 | | |
45 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
| 41 | + | |
43 | 42 | | |
44 | 43 | | |
45 | 44 | | |
| |||
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | | - | |
| 43 | + | |
45 | 44 | | |
46 | 45 | | |
47 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
54 | | - | |
| 53 | + | |
55 | 54 | | |
56 | 55 | | |
57 | 56 | | |
| |||
0 commit comments