fix array order for diagnostic buckets

Author: grantfirl

scm/src/GFS_typedefs.F90

@@ -8131,7 +8131,7 @@ subroutine diag_create (Diag, Model)
     allocate (Diag%dtsfc   (IM))
     allocate (Diag%dqsfc   (IM))
     allocate (Diag%totprcp (IM))
-    allocate (Diag%totprcpb(ndb,IM))
+    allocate (Diag%totprcpb(IM,ndb))
     allocate (Diag%gflux   (IM))
     allocate (Diag%dlwsfc  (IM))
     allocate (Diag%ulwsfc  (IM))
@@ -8146,7 +8146,7 @@ subroutine diag_create (Diag, Model)
     allocate (Diag%dvgwd   (IM))
     allocate (Diag%psmean  (IM))
     allocate (Diag%cnvprcp (IM))
-    allocate (Diag%cnvprcpb(ndb,IM))
+    allocate (Diag%cnvprcpb(IM,ndb))
     allocate (Diag%spfhmin (IM))
     allocate (Diag%spfhmax (IM))
     allocate (Diag%u10mmax (IM))

scm/src/GFS_typedefs.meta

@@ -9260,7 +9260,7 @@
   standard_name = accumulated_lwe_thickness_of_precipitation_amount_in_bucket
   long_name = accumulated total precipitation in bucket
   units = m
-  dimensions = (number_of_diagnostic_buckets,horizontal_dimension)
+  dimensions = (horizontal_dimension,number_of_diagnostic_buckets)
   type = real
   kind = kind_phys
 [toticeb]
@@ -9451,7 +9451,7 @@
   standard_name = cumulative_lwe_thickness_of_convective_precipitation_amount_in_bucket
   long_name = cumulative convective precipitation in bucket
   units = m
-  dimensions = (number_of_diagnostic_buckets,horizontal_dimension)
+  dimensions = (horizontal_dimension,number_of_diagnostic_buckets)
   type = real
   kind = kind_phys
 [spfhmin]

scm/src/scm_output.F90

@@ -788,16 +788,16 @@ subroutine output_append_diag_avg(ncid, scm_state, physics)
     call output_append_tendency(ncid, physics, physics%Model%dtidx(physics%Model%index_of_y_wind,physics%Model%index_of_process_physics),           "dv_dt_phys",     scm_state%itt_diag, inverse_n_diag*inverse_dt)
     call output_append_tendency(ncid, physics, physics%Model%dtidx(physics%Model%index_of_y_wind,physics%Model%index_of_process_non_physics),       "dv_dt_nonphys",  scm_state%itt_diag, inverse_n_diag*inverse_dt)
 
-    call NetCDF_put_var(ncid, "tprcp_accum",          physics%Diag%totprcpb(1,:), scm_state%itt_diag, inverse_n_diag)
+    call NetCDF_put_var(ncid, "tprcp_accum",          physics%Diag%totprcpb(:,1), scm_state%itt_diag, inverse_n_diag)
     call NetCDF_put_var(ncid, "ice_accum",            physics%Diag%toticeb(:),  scm_state%itt_diag, inverse_n_diag)
     call NetCDF_put_var(ncid, "snow_accum",           physics%Diag%totsnwb(:),  scm_state%itt_diag, inverse_n_diag)
     call NetCDF_put_var(ncid, "graupel_accum",        physics%Diag%totgrpb(:),  scm_state%itt_diag, inverse_n_diag)
-    call NetCDF_put_var(ncid, "conv_prcp_accum",      physics%Diag%cnvprcpb(1,:), scm_state%itt_diag, inverse_n_diag)
-    call NetCDF_put_var(ncid, "tprcp_rate_accum",     physics%Diag%totprcpb(1,:), scm_state%itt_diag, inverse_n_diag*inverse_dt)
+    call NetCDF_put_var(ncid, "conv_prcp_accum",      physics%Diag%cnvprcpb(:,1), scm_state%itt_diag, inverse_n_diag)
+    call NetCDF_put_var(ncid, "tprcp_rate_accum",     physics%Diag%totprcpb(:,1), scm_state%itt_diag, inverse_n_diag*inverse_dt)
     call NetCDF_put_var(ncid, "ice_rate_accum",       physics%Diag%toticeb(:),  scm_state%itt_diag, inverse_n_diag*inverse_dt)
     call NetCDF_put_var(ncid, "snow_rate_accum",      physics%Diag%totsnwb(:),  scm_state%itt_diag, inverse_n_diag*inverse_dt)
     call NetCDF_put_var(ncid, "graupel_rate_accum",   physics%Diag%totgrpb(:),  scm_state%itt_diag, inverse_n_diag*inverse_dt)
-    call NetCDF_put_var(ncid, "conv_prcp_rate_accum", physics%Diag%cnvprcpb(1,:), scm_state%itt_diag, inverse_n_diag*inverse_dt)
+    call NetCDF_put_var(ncid, "conv_prcp_rate_accum", physics%Diag%cnvprcpb(:,1), scm_state%itt_diag, inverse_n_diag*inverse_dt)
 
 end subroutine output_append_diag_avg