Merge PR #8 into 16.0

Signed-off-by legalsylvain

Author: github-grap-bot

.copier-answers.yml

@@ -1,5 +1,5 @@
 # Do NOT update manually; changes here will be overwritten by Copier
-_commit: 352dc52
+_commit: 51c8c81
 _src_path: https://github.com/grap/oca-addons-repo-template-v16
 additional_ruff_rules: []
 ci: GitHub

.github/workflows/pre-commit.yml

@@ -17,6 +17,7 @@ jobs:
       - uses: actions/setup-python@v5
         with:
           python-version: "3.11"
+          cache: 'pip'
       - name: Get python version
         run: echo "PY=$(python -VV | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV
       - uses: actions/cache@v4

.github/workflows/test.yml

@@ -45,6 +45,13 @@ jobs:
         run: oca_init_test_database
       - name: Run tests
         run: oca_run_tests
+      - name: Upload screenshots from JS tests
+        uses: actions/upload-artifact@v4
+        if: ${{ failure() }}
+        with:
+          name: Screenshots of failed JS tests - ${{ matrix.name }}${{ join(matrix.include) }}
+          path: /tmp/odoo_tests/${{ env.PGDATABASE }}
+          if-no-files-found: ignore
       - uses: codecov/codecov-action@v4
         with:
           token: ${{ secrets.CODECOV_TOKEN }}

.pre-commit-config.yaml

@@ -62,36 +62,6 @@ repos:
       - id: oca-checks-po
         args:
           - --disable=po-pretty-format
-  - repo: https://github.com/myint/autoflake
-    rev: v1.6.1
-    hooks:
-      - id: autoflake
-        args:
-          - --expand-star-imports
-          - --ignore-init-module-imports
-          - --in-place
-          - --remove-all-unused-imports
-          - --remove-duplicate-keys
-          - --remove-unused-variables
-  - repo: https://github.com/psf/black
-    rev: 22.8.0
-    hooks:
-      - id: black
-  - repo: local
-    hooks:
-      - id: eslint
-        name: eslint
-        entry: eslint
-        args:
-          - --color
-          - --fix
-        verbose: true
-        types: [javascript]
-        language: node
-        additional_dependencies:
-          - "eslint@8.24.0"
-          - "eslint-plugin-jsdoc@"
-          - "globals@"
   - repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v4.3.0
     hooks:
@@ -114,21 +84,8 @@ repos:
       - id: check-xml
       - id: mixed-line-ending
         args: ["--fix=lf"]
-  - repo: https://github.com/asottile/pyupgrade
-    rev: v2.38.2
-    hooks:
-      - id: pyupgrade
-        args: ["--keep-percent-format"]
-  - repo: https://github.com/PyCQA/isort
-    rev: 5.12.0
-    hooks:
-      - id: isort
-        name: isort except __init__.py
-        args:
-          - --settings=.
-        exclude: /__init__\.py$
   - repo: https://github.com/acsone/setuptools-odoo
-    rev: 3.1.8
+    rev: 3.3.2
     hooks:
       - id: setuptools-odoo-make-default
       - id: setuptools-odoo-get-requirements
@@ -137,12 +94,12 @@ repos:
           - requirements.txt
           - --header
           - "# generated from manifests external_dependencies"
-  - repo: https://github.com/PyCQA/flake8
-    rev: 5.0.0
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.1.3
     hooks:
-      - id: flake8
-        name: flake8
-        additional_dependencies: ["flake8-bugbear==21.9.2"]
+      - id: ruff
+        args: [--fix, --exit-non-zero-on-fix]
+      - id: ruff-format
   - repo: https://github.com/OCA/pylint-odoo
     rev: v8.0.19
     hooks:

.pylintrc

@@ -99,22 +99,22 @@ enable=anomalous-backslash-in-string,
     translation-positional-used,
     website-manifest-key-not-valid-uri,
     external-request-timeout,
-    # messages that do not cause the lint step to fail
-    consider-merging-classes-inherited,
+    missing-manifest-dependency,
+    too-complex,,
     create-user-wo-reset-password,
     dangerous-filter-wo-user,
-    deprecated-module,
     file-not-used,
-    invalid-commit,
-    missing-manifest-dependency,
     missing-newline-extrafiles,
-    missing-readme,
     no-utf8-coding-comment,
-    odoo-addons-relative-import,
     old-api7-method-defined,
-    redefined-builtin,
-    too-complex,
     unnecessary-utf8-coding-comment,
+    # messages that do not cause the lint step to fail
+    consider-merging-classes-inherited,
+    deprecated-module,
+    invalid-commit,
+    missing-readme,
+    odoo-addons-relative-import,
+    redefined-builtin,
     manifest-external-assets
 
 

.ruff.toml

@@ -0,0 +1,31 @@
+
+target-version = "py310"
+fix = true
+
+[lint]
+extend-select = [
+    "B",
+    "C90",
+    "E501",  # line too long (default 88)
+    "I",  # isort
+    "UP",  # pyupgrade
+]
+extend-safe-fixes = ["UP008"]
+exclude = ["setup/*"]
+
+[format]
+exclude = ["setup/*"]
+
+[per-file-ignores]
+"__init__.py" = ["F401", "I001"]  # ignore unused and unsorted imports in __init__.py
+"__manifest__.py" = ["B018"]  # useless expression
+
+[isort]
+section-order = ["future", "standard-library", "third-party", "odoo", "odoo-addons", "first-party", "local-folder"]
+
+[isort.sections]
+"odoo" = ["odoo"]
+"odoo-addons" = ["odoo.addons"]
+
+[mccabe]
+max-complexity = 16

fermente_custom_import_account_product_fiscal_classification/models/custom_import_product_mixin.py

@@ -61,7 +61,8 @@ def _custom_import_handle_fiscal_classification_id(self, old_vals, new_vals):
         else:
             raise ValidationError(
                 _(
-                    "Many Fiscal Classifications Found for the product %(product_name)s."
+                    "Many Fiscal Classifications Found"
+                    " for the product %(product_name)s."
                     " Vat Amount %(vat_amount)s."
                     " Fiscal Classifications : %(classification_names)s",
                     product_name=old_vals.get("name"),

fermente_custom_import_demo/models/product_template.py

@@ -13,6 +13,9 @@ def get_import_templates(self):
         return [
             {
                 "label": _("Import Template for Fermente CAE"),
-                "template": "fermente_custom_import_product/static/xlsx/template_product.xlsx",
+                "template": (
+                    "fermente_custom_import_product/"
+                    "static/xlsx/template_product.xlsx"
+                ),
             }
         ]

fermente_custom_import_partner_firstname/models/custom_import_partner_mixin.py

@@ -27,7 +27,8 @@ def _custom_import_hook_check(self, vals_list):
             if (vals.get("firstname") or vals.get("lastname")) and vals.get("name"):
                 raise ValidationError(
                     _(
-                        "The file contains contacts that has first name or last name AND"
+                        "The file contains contacts that"
+                        " has first name or last name AND"
                         " name fields defined. Please set a name for a company"
                         " or a first name / last name for an individual."
                         " First Name: %(firstname)s ; "

requirements.txt

@@ -0,0 +1 @@
+# generated from manifests external_dependencies