Small improvements (#730)

* chore: ignore dot files

Co-authored-by: Copilot <copilot@github.com>

* chore: go ignore node_modules

* test: use noop test panic logger

* refactor: query errors str builder

* docs: update testdata readme

---------

Co-authored-by: Copilot <copilot@github.com>

Author: pavelnikolov

.gitignore

@@ -3,3 +3,6 @@
 /internal/validation/testdata/graphql-js
 /internal/validation/testdata/node_modules
 /vendor
+/specs
+/.*
+/!.github/workflows

errors/errors.go

@@ -2,6 +2,7 @@ package errors
 
 import (
 	"fmt"
+	"strings"
 )
 
 type QueryError struct {
@@ -42,11 +43,12 @@ func (err *QueryError) Error() string {
 	if err == nil {
 		return "<nil>"
 	}
-	str := fmt.Sprintf("graphql: %s", err.Message)
+	var str strings.Builder
+	fmt.Fprintf(&str, "graphql: %s", err.Message)
 	for _, loc := range err.Locations {
-		str += fmt.Sprintf(" (line %d, column %d)", loc.Line, loc.Column)
+		fmt.Fprintf(&str, " (line %d, column %d)", loc.Line, loc.Column)
 	}
-	return str
+	return str.String()
 }
 
 func (err *QueryError) Unwrap() error {

go.mod

@@ -15,3 +15,7 @@ require (
 	go.opentelemetry.io/auto/sdk v1.2.1 // indirect
 	go.opentelemetry.io/otel/metric v1.43.0 // indirect
 )
+
+ignore (
+    "./internal/validation/testdata/node_modules/**"
+)

internal/validation/testdata/README.md

@@ -12,13 +12,9 @@ go generate .
 
 ## How it works
 
-A Node.js project is used to pull in graphql-js as a dependency. The `export.cjs` script runs with Node,
-transpiles graphql-js TypeScript files on the fly, loads selected validation test files with a lightweight in-process Mocha shim, and captures expected validation errors into `tests.json`. These test cases in the JSON file are then used to drive the Go tests.
+A Node.js project is used to pull in graphql-js as a dependency. The `export.cjs` script runs with Node, transpiles graphql-js TypeScript files on the fly, loads selected validation test files with a lightweight in-process Mocha shim, and captures expected validation errors into `tests.json`. These test cases in the JSON file are then used to drive the Go tests.
 
-Some upstream validation suites are intentionally disabled in `export.cjs` when
-they rely on currently unsupported behavior (for example, subscription-only
-fixtures) or known parser/validation parity gaps. Each disabled import has an
-inline rationale and should be re-evaluated as parity work progresses.
+Some upstream validation suites are intentionally disabled in `export.cjs` when they rely on currently unsupported behavior (for example, subscription-only fixtures) or known parser/validation parity gaps. Each disabled import has an inline rationale and should be re-evaluated as parity work progresses.
 
 ## Updating dependency
 

subscription_test.go

@@ -12,6 +12,7 @@ import (
 	graphql "github.com/graph-gophers/graphql-go"
 	qerrors "github.com/graph-gophers/graphql-go/errors"
 	"github.com/graph-gophers/graphql-go/gqltesting"
+	"github.com/graph-gophers/graphql-go/log"
 )
 
 type rootResolver struct {
@@ -606,6 +607,7 @@ func (r *subscriptionsPanicInResolver) OnPanic() <-chan string {
 }
 
 func TestSchemaSubscribe_PanicInResolver(t *testing.T) {
+	noop := log.LoggerFunc(func(_ context.Context, _ any) {})
 	r := &struct {
 		*subscriptionsPanicInResolver
 		Name string
@@ -620,7 +622,7 @@ func TestSchemaSubscribe_PanicInResolver(t *testing.T) {
 			type Subscription {
 				onPanic : String!
 			}
-		`, r, graphql.UseFieldResolvers()),
+		`, r, graphql.UseFieldResolvers(), graphql.Logger(noop)),
 		Query: `
 			subscription {
 				onPanic