fix(dips): warn when accepted rows can't be retired without the subgraph

Accepting a proposal needs the indexing-payments subgraph, so the local accepted rows can only
appear without one if it was unset after acceptance. The retirement path then can't run and the
rules are kept silently; warn with the stuck deployments so the misconfiguration is visible.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: MoonBoi9001

packages/indexer-common/src/indexing-fees/__tests__/dips.test.ts

@@ -617,6 +617,50 @@ describe('DipsManager', () => {
       expect(markCompleted).toHaveBeenCalledWith('accepted-1')
     })
 
+    test('keeps accepted rows and warns when no indexing-payments subgraph is configured', async () => {
+      await managementModels.IndexingRule.create({
+        identifier: testDeploymentId,
+        identifierType: SubgraphIdentifierType.DEPLOYMENT,
+        decisionBasis: IndexingDecisionBasis.DIPS,
+        protocolNetwork: 'eip155:421614',
+        allocationLifetime: 3600,
+      })
+      jest
+        .spyOn(dipsManager.pendingRcaConsumer!, 'getPendingProposals')
+        .mockResolvedValue([])
+      jest
+        .spyOn(dipsManager.pendingRcaConsumer!, 'getAcceptedProposals')
+        .mockResolvedValue([
+          {
+            id: 'accepted-1',
+            agreementId: testAgreementId,
+            status: 'accepted',
+            createdAt: new Date(),
+            updatedAt: new Date(),
+            subgraphDeploymentId: new SubgraphDeploymentID(testDeploymentId),
+            minSecondsPerCollection: 60,
+            maxSecondsPerCollection: 3600,
+          } as never,
+        ])
+      const markCompleted = jest.spyOn(dipsManager.pendingRcaConsumer!, 'markCompleted')
+      const warn = jest.spyOn(logger, 'warn')
+      // No subgraph configured: it can't drive retirement, so the rule is kept and
+      // the stuck state is surfaced rather than lingering silently forever.
+      network.indexingPaymentsSubgraph = undefined
+
+      await dipsManager.ensureAgreementRules()
+
+      expect(markCompleted).not.toHaveBeenCalled()
+      expect(warn).toHaveBeenCalledWith(
+        expect.stringContaining(
+          'cannot be retired without the indexing-payments subgraph',
+        ),
+        expect.objectContaining({
+          stuckDeployments: [new SubgraphDeploymentID(testDeploymentId).toString()],
+        }),
+      )
+    })
+
     test('retires the accepted row and reaps its rule once the subgraph catches up but the agreement is gone', async () => {
       await managementModels.IndexingRule.create({
         identifier: testDeploymentId,

packages/indexer-common/src/indexing-fees/dips.ts

@@ -235,6 +235,19 @@ export class DipsManager {
           })
         }
       }
+    } else if (fromAcceptedProposals.length > 0) {
+      // No subgraph configured but accepted rows exist (it was unset after they
+      // were accepted): we can't tell if their agreements still live, so surface
+      // the stuck rows instead of silently keeping their rules forever.
+      this.logger.warn(
+        'DIPS accepted rows cannot be retired without the indexing-payments subgraph; ' +
+          'their rules will be kept until it is configured',
+        {
+          stuckDeployments: fromAcceptedProposals.map((p) =>
+            p.subgraphDeploymentId.toString(),
+          ),
+        },
+      )
     }
   }