Error Masking incorrectly sets `extensions.originalError` vs `error.originalError`

[rwe]

Describe the bug

The default maskError implementation sets originalError within the GraphQLErrorExtensions versus the GraphQLErrorOptions itself.

Note that originalError is a standard GraphQLError field: https://github.com/graphql/graphql-js/blob/0a848cc4c781fb79b2e55eb8d011675dd612524f/src/error/GraphQLError.ts#L41-L42

Although it's possible this was intended, e.g. to bypass some later error processing(?), it seems unlikely. Punning originalError from GraphQLErrorOptions into GraphQLErrorExtensions inconsistent with other usage and checks of originalError.

This is done in a few places:

graphql-yoga/packages/graphql-yoga/src/utils/mask-error.ts

Lines 38 to 44 in c3e7fdd

	return createGraphQLError(message, {
	extensions: {
	code: 'INTERNAL_SERVER_ERROR',
	unexpected: true,
	originalError: isDev
	? error instanceof Error
	? {

Both of the constructors in that file seem like they were intended to be written as:

 return createGraphQLError(message, {
+  originalError: isDev
+    ? error instanceof Error
+      ? {
+          message: error.message,
+          stack: error.stack,
+        }
+      : error
+    : undefined,
   extensions: {
     code: 'INTERNAL_SERVER_ERROR',
     unexpected: true,
-    originalError: isDev
-      ? error instanceof Error
-        ? {
-            message: error.message,
-            stack: error.stack,
-          }
-        : error
-      : undefined,
   },
 });

It's also done here:

• graphql-yoga/packages/graphql-yoga/src/plugins/request-parser/post-json.ts

  Line 58 in c3e7fdd

  extensions['originalError'] = {

• graphql-yoga/packages/graphql-yoga/src/plugins/result-processor/regular.ts

  Line 39 in c3e7fdd

  !err.extensions?.['originalError'] || isGraphQLError(err.extensions['originalError']),

• graphql-yoga/website/src/content/tutorial/basic/09-error-handling.mdx

  Line 65 in c3e7fdd

  "originalError": {

However, those seem to be derived from the same source of confusion to be self-consistent, rather than a design decision, since there are no comments indicating that that was intentional.

Your Example Website or App

https://invalid

Steps to Reproduce the Bug or Issue

1. Go to the above links and read the code.

Expected behavior

As a user, I expected extensions to include reasonable properties and not a single property that was supposed to be on the GraphQLError itself.

Screenshots or Videos

No response

Platform

• GitHub

Additional context

Way too many "required" fields on this issue template.

[ardatan]

error.extensions.originalError is intentional in order to allow users to see the original error details when isDev is enabled.
error.originalError has a different purpose.

Way too many "required" fields on this issue template.

Could you explain how this affects your use case? We actually have those fields to understand your use case and help you better. Thanks.