Skip to content

Commit 3d3393f

Browse files
committed
Minor cleanup and simplification
1 parent e8035a8 commit 3d3393f

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

src/graphql/validation/rules/overlapping_fields_can_be_merged.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -603,10 +603,10 @@ def same_arguments(
603603
args1 = node1.arguments
604604
args2 = node2.arguments
605605

606-
if args1 is None or len(args1) == 0:
607-
return args2 is None or len(args2) == 0
606+
if not args1:
607+
return not args2
608608

609-
if args2 is None or len(args2) == 0:
609+
if not args2:
610610
return False
611611

612612
if len(args1) != len(args2):

tests/benchmarks/test_repeated_fields_benchmark.py tests/benchmarks/test_repeated_fields.py

+3-5
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,20 @@
66
graphql_sync,
77
)
88

9-
109
schema = GraphQLSchema(
1110
query=GraphQLObjectType(
1211
name="Query",
1312
fields={
1413
"hello": GraphQLField(
1514
GraphQLString,
16-
resolve=lambda obj, info: "world",
15+
resolve=lambda _obj, _info: "world",
1716
)
1817
},
1918
)
2019
)
21-
source = "query {{ {fields} }}".format(fields="hello " * 250)
20+
source = f"{{ {'hello ' * 250}}}"
2221

2322

2423
def test_many_repeated_fields(benchmark):
25-
print(source)
2624
result = benchmark(lambda: graphql_sync(schema, source))
27-
assert not result.errors
25+
assert result == ({"hello": "world"}, None)

tests/execution/test_stream.py

+1
Original file line numberDiff line numberDiff line change
@@ -1297,6 +1297,7 @@ async def friend_list(_info):
12971297
]
12981298

12991299
@pytest.mark.asyncio()
1300+
@pytest.mark.filterwarnings("ignore:.* was never awaited:RuntimeWarning")
13001301
async def filters_stream_payloads_that_are_nulled_in_a_deferred_payload():
13011302
document = parse(
13021303
"""

0 commit comments

Comments
 (0)