[language-service] parsing error for string template variables in a "default argument value" position

[ezracelli]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

I'd love to be able to extract default argument values into constants, so I can:

• avoid "magic values" in the schema
• use the constant default values inside other functions

This is the pattern I'd like to implement:

const schema = gql`
  type ImageAsset {
    src(
      height: Int
      width: Int = ${DEFAULT_WIDTH}
    ): ImageSource!
  }
`;

... which unfortunately leads to a parsing error: Syntax Error: Unexpected ")".

Expected Behavior

vscode-graphql should understand that this is, at the very least, "some default value" (understandable that it probably won't be able to grab the exact value — that would be pretty awesome, though!)

Steps To Reproduce

const schema = gql`
  type ImageAsset {
    src(
      height: Int
      width: Int = ${DEFAULT_WIDTH}
    ): ImageSource!
  }
`;

Environment

- VSCode extension `graphql.vscode-graphql` Version: 0.7.5
- OS: MacOS Ventura (13.0 Beta, build 22A5352e)

Anything else?

No response

[acao]

@ezracelli the problem here is that graphql-js validate (called by the lsp server) doesn’t understand the template replacement going on here - it just sees a broken graphql string. It should be replacing template string expressions with whitespace in this case as it does with completion and other features, but for whatever reason it seems to be giving you this error

[VinceBT-BG]

I am encountering the same issue, did you find a workaround @ezracelli ?

[ezracelli]

I did not, unfortunately! Just dealt with the red squiggles 😁