Skip to content

Commit 56d11b0

Browse files
authored
docs: Stabilise Lighthouse line numbers (#123)
1 parent 9985b4f commit 56d11b0

File tree

5 files changed

+608
-508
lines changed

5 files changed

+608
-508
lines changed

.github/workflows/audits.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,10 @@ jobs:
6565
workspace:
6666
- deno
6767
- hotchocolate
68+
- lighthouse
6869
- postgraphile
6970
# TODO: speed up build process
7071
# - pioneer
71-
# TODO: ensure consistant results
72-
# - lighthouse
7372
env:
7473
PORT: 4000
7574
steps:

CONTRIBUTING.md

+18-4
Original file line numberDiff line numberDiff line change
@@ -23,22 +23,36 @@ Every implementation is expected to contain a `package.json` file with at least
2323
"name": "implementation-name", // should be equivalent to the directory name
2424
"url": "https://implementation-name.example", // the official project URL
2525
"scripts": {
26-
"start": "node ." | "docker-compose up -d" // depending if the server can be run through node or Docker
26+
"start": "node ." | "docker compose up" // depending if the server can be run through Node.js or Docker
2727
}
2828
}
2929
```
3030

3131
Depending on how your server is run, add it to the appropriate section of [.github/workflows/audits.yml](.github/workflows/audits.yml):
3232

33-
- `node .`: `jobs.javascript.strategy.matrix.workspace`
34-
- `docker-compose up -d`: `jobs.docker.strategy.matrix.workspace`
33+
- Node.js: `jobs.javascript.strategy.matrix.workspace`
34+
- Docker: `jobs.docker.strategy.matrix.workspace`
3535

3636
The script run in `start` is expected to bring up an HTTP server that listens to the port defined in the environment variable `$PORT`.
3737

3838
After adding your directory and `package.json`, run `yarn install` to include the workspace.
3939

40+
You may run the audit on your implementation locally by first bringing up the server:
41+
42+
```shell
43+
PORT=4000 yarn workspace <implementation> start
44+
```
45+
46+
Then open another shell or move the prior process to the background and run:
47+
48+
```shell
49+
PORT=4000 yarn tsx scripts/audit-implementation.ts implementations/<implementation>
50+
```
51+
4052
## Code formatting
4153

4254
Run the following script to ensure the automatic code formatting is applied:
4355

44-
yarn run lint:fix
56+
```shell
57+
yarn run lint:fix
58+
```

implementations/lighthouse/Dockerfile

+16-7
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,26 @@
1-
FROM php:8.1.21-cli
2-
3-
WORKDIR /app
1+
# See https://hub.docker.com/_/php/tags?page=&page_size=&ordering=&name=cli.
2+
FROM php:8.2.19-cli
43

4+
# See https://getcomposer.org.
55
COPY --from=composer /usr/bin/composer /usr/bin/composer
66

7-
RUN apt-get update && \
8-
apt-get install --yes \
7+
# Required to make the composer installations work.
8+
RUN apt-get update \
9+
&& apt-get install --yes \
910
git \
1011
libzip-dev \
1112
zip \
1213
&& docker-php-ext-install \
1314
zip \
1415
&& rm -rf /var/lib/apt/lists/*
15-
RUN composer create-project laravel/laravel /app
16-
RUN composer require nuwave/lighthouse 6.14.0
16+
17+
# Creating a project following https://laravel.com/docs/installation#creating-a-laravel-project.
18+
# See https://github.com/laravel/laravel/releases for new versions.
19+
WORKDIR /app
20+
RUN composer create-project laravel/laravel=11.1.1 /app
21+
22+
# See https://github.com/nuwave/lighthouse/releases for new versions.
23+
RUN composer require nuwave/lighthouse:6.36.3
24+
25+
# Following https://lighthouse-php.com/6/getting-started/installation.html#publish-the-default-schema.
1726
RUN php artisan vendor:publish --tag=lighthouse-schema

0 commit comments

Comments
 (0)