Clarify "response key" vs "response name"

[duckki]

Both terms are used in the spec and it appears that they are the same thing.

• Sec. 2.7 defines "response key" as
  • "By default a field’s response key in the response object will use that field’s name. However, you can define a different response key by specifying an alias."
• Sec. 5.3.2 uses "response name" without a definition.
• Sec. 6.3.2 uses "response key" with a definition in parentheses as
  • "the alias if defined, otherwise the field name."

Consistency would be appreciated. Or, if they are different, please add a definition for response name.

I see some implementations use "response name" and others use "response key". In the graphql-js codebase, only responseName is used.

• OverlappingFieldsCanBeMergedRule.ts#L86
• execute.ts#L409

[martinbonnin]

+1. My personal preference goes to response name as it's what we use in Apollo Kotlin too.

[benjie]

Good spot @duckki! Since I already added a definition for "response key" in #1039, I've pulled that out into #1147 and then standardized our terminology around it.

[benjie]

Actually given GraphQL.js uses responseName we should just go with that. Editing #1147

[andimarek]

I would argue for response key over response name. It is the clearer word for what aliases cause in the overall response: the key in the map of the result is changed. We already have field names and then response names is to close to each other imho.