Skip to content

Commit 7e79665

Browse files
authored
feat(design): deprecate DaffPrefixSuffixModule and add component array option (#4273)
1 parent 69fbc83 commit 7e79665

11 files changed

Lines changed: 39 additions & 42 deletions

File tree

libs/design-examples/tabs/src/basic-tabs/basic-tabs.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
import { FaIconComponent } from '@fortawesome/angular-fontawesome';
66
import { faInfoCircle } from '@fortawesome/free-solid-svg-icons';
77

8-
import { DaffPrefixSuffixModule } from '@daffodil/design';
8+
import { DAFF_PREFIX_SUFFIX_DIRECTIVES } from '@daffodil/design';
99
import { DAFF_TABS_COMPONENTS } from '@daffodil/design/tabs';
1010

1111
@Component({
@@ -15,7 +15,7 @@ import { DAFF_TABS_COMPONENTS } from '@daffodil/design/tabs';
1515
imports: [
1616
DAFF_TABS_COMPONENTS,
1717
FaIconComponent,
18-
DaffPrefixSuffixModule,
18+
DAFF_PREFIX_SUFFIX_DIRECTIVES,
1919
],
2020
})
2121
export class BasicTabsExampleComponent {

libs/design-examples/tabs/src/custom-select-tabs/custom-select-tabs.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
import { FaIconComponent } from '@fortawesome/angular-fontawesome';
77
import { faInfoCircle } from '@fortawesome/free-solid-svg-icons';
88

9-
import { DaffPrefixSuffixModule } from '@daffodil/design';
9+
import { DAFF_PREFIX_SUFFIX_DIRECTIVES } from '@daffodil/design';
1010
import { DaffButtonComponent } from '@daffodil/design/button';
1111
import {
1212
DAFF_TABS_COMPONENTS,
@@ -22,7 +22,7 @@ import {
2222
DAFF_TABS_COMPONENTS,
2323
DaffButtonComponent,
2424
FaIconComponent,
25-
DaffPrefixSuffixModule,
25+
DAFF_PREFIX_SUFFIX_DIRECTIVES,
2626
],
2727
})
2828
export class CustomSelectTabsExampleComponent {

libs/design-examples/tabs/src/disabled-tabs/disabled-tabs.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
import { FaIconComponent } from '@fortawesome/angular-fontawesome';
66
import { faInfoCircle } from '@fortawesome/free-solid-svg-icons';
77

8-
import { DaffPrefixSuffixModule } from '@daffodil/design';
8+
import { DAFF_PREFIX_SUFFIX_DIRECTIVES } from '@daffodil/design';
99
import { DAFF_TABS_COMPONENTS } from '@daffodil/design/tabs';
1010

1111
@Component({
@@ -15,7 +15,7 @@ import { DAFF_TABS_COMPONENTS } from '@daffodil/design/tabs';
1515
imports: [
1616
DAFF_TABS_COMPONENTS,
1717
FaIconComponent,
18-
DaffPrefixSuffixModule,
18+
DAFF_PREFIX_SUFFIX_DIRECTIVES,
1919
],
2020
})
2121
export class DisabledTabsExampleComponent {

libs/design-examples/tabs/src/initially-select-tab/initially-select-tab.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
import { FaIconComponent } from '@fortawesome/angular-fontawesome';
66
import { faInfoCircle } from '@fortawesome/free-solid-svg-icons';
77

8-
import { DaffPrefixSuffixModule } from '@daffodil/design';
8+
import { DAFF_PREFIX_SUFFIX_DIRECTIVES } from '@daffodil/design';
99
import { DAFF_TABS_COMPONENTS } from '@daffodil/design/tabs';
1010

1111
@Component({
@@ -15,7 +15,7 @@ import { DAFF_TABS_COMPONENTS } from '@daffodil/design/tabs';
1515
imports: [
1616
DAFF_TABS_COMPONENTS,
1717
FaIconComponent,
18-
DaffPrefixSuffixModule,
18+
DAFF_PREFIX_SUFFIX_DIRECTIVES,
1919
],
2020
})
2121
export class InitiallySelectTabExampleComponent {

libs/design-examples/tabs/src/link-tabs/link-tabs.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
import { FaIconComponent } from '@fortawesome/angular-fontawesome';
66
import { faInfoCircle } from '@fortawesome/free-solid-svg-icons';
77

8-
import { DaffPrefixSuffixModule } from '@daffodil/design';
8+
import { DAFF_PREFIX_SUFFIX_DIRECTIVES } from '@daffodil/design';
99
import { DAFF_TABS_COMPONENTS } from '@daffodil/design/tabs';
1010

1111
@Component({
@@ -15,7 +15,7 @@ import { DAFF_TABS_COMPONENTS } from '@daffodil/design/tabs';
1515
imports: [
1616
DAFF_TABS_COMPONENTS,
1717
FaIconComponent,
18-
DaffPrefixSuffixModule,
18+
DAFF_PREFIX_SUFFIX_DIRECTIVES,
1919
],
2020
})
2121
export class LinkTabsExampleComponent {

libs/design/src/core/prefix-suffix/prefix-suffix.module.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ import { NgModule } from '@angular/core';
33
import { DaffPrefixDirective } from './prefix.directive';
44
import { DaffSuffixDirective } from './suffix.directive';
55

6+
/**
7+
* @deprecated in favor of standalone components. Deprecated in version 0.91.0. Will be removed in version 1.0.0.
8+
*/
69
@NgModule({
710
imports: [
811
DaffPrefixDirective,
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import { DaffPrefixDirective } from './prefix.directive';
2+
import { DaffSuffixDirective } from './suffix.directive';
3+
4+
export const DAFF_PREFIX_SUFFIX_DIRECTIVES = <const> [
5+
DaffPrefixDirective,
6+
DaffSuffixDirective,
7+
];
Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,13 @@
1-
import {
2-
Directive,
3-
HostBinding,
4-
} from '@angular/core';
1+
import { Directive } from '@angular/core';
52

63
/**
7-
*
8-
* Prefix can be used to place content before another piece of content in components like
9-
* `daff-form-field`, `daff-solo-field`, and `daff-list`.
4+
* DaffPrefixDirective can be used to place content before another piece of content
5+
* in components like `DaffFormFieldComponent` or `DaffListComponent`.
106
*/
117
@Directive({
128
selector: '[daffPrefix]',
9+
host: {
10+
class: 'daff-prefix',
11+
},
1312
})
14-
export class DaffPrefixDirective {
15-
16-
/**
17-
* @docs-private
18-
*/
19-
@HostBinding('class.daff-prefix') class = true;
20-
}
13+
export class DaffPrefixDirective {}
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
export * from './prefix-suffix.module';
2-
export * from './prefix.directive';
3-
export * from './suffix.directive';
2+
export { DaffPrefixDirective } from './prefix.directive';
3+
export { DaffSuffixDirective } from './suffix.directive';
4+
export { DAFF_PREFIX_SUFFIX_DIRECTIVES } from './prefix-suffix';
Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,13 @@
1-
import {
2-
Directive,
3-
HostBinding,
4-
} from '@angular/core';
1+
import { Directive } from '@angular/core';
52

63
/**
7-
*
8-
* Prefix can be used to place content after another piece of content in components like
9-
* `daff-form-field`, `daff-solo-field`, and `daff-list`.
4+
* DaffSuffixDirective can be used to place content after another piece of content
5+
* in components like `DaffFormFieldComponent` or `DaffListComponent`.
106
*/
117
@Directive({
128
selector: '[daffSuffix]',
9+
host: {
10+
class: 'daff-suffix',
11+
},
1312
})
14-
export class DaffSuffixDirective {
15-
16-
/**
17-
* @docs-private
18-
*/
19-
@HostBinding('class.daff-suffix') class = true;
20-
}
13+
export class DaffSuffixDirective { }

0 commit comments

Comments
 (0)