Skip to content

Commit 1e9964c

Browse files
authored
Fix flashing when clicking around (commaai#455)
Closes commaai/connect#454 Not sure why the RouteStatistics animation in the RouteActivity is gone again, but oh well @incognitojam we can probably remove a bunch of Suspense's. Maybe the rule of thumb is; you don't want a Suspense without a fallback?
1 parent 2280061 commit 1e9964c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/components/Timeline.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { For, createResource, createSignal, createEffect, onMount, onCleanup, Suspense } from 'solid-js'
1+
import { For, createResource, createSignal, createEffect, onMount, onCleanup } from 'solid-js'
22
import type { VoidComponent } from 'solid-js'
33
import clsx from 'clsx'
44

@@ -176,7 +176,7 @@ const Timeline: VoidComponent<TimelineProps> = (props) => {
176176
)}
177177
title="Disengaged"
178178
>
179-
<Suspense fallback={<div class="skeleton-loader size-full"></div>}>{renderTimelineEvents(props.route, props.events)}</Suspense>
179+
{renderTimelineEvents(props.route, props.events)}
180180
<div
181181
class="absolute top-0 z-10 h-full"
182182
style={{

0 commit comments

Comments
 (0)