fix: prevent infinite loading of RouteList on shared device (commaai#511)

greatgitsby · web-flow · commit 3c7baa513fb5 · 2025-04-07T00:24:13.000-07:00
fixes point 2 of commaai/connect#506 ## before https://github.com/user-attachments/assets/648cd0e6-0d7e-4569-9a30-8960dc5a344b ## after https://github.com/user-attachments/assets/f924c8cd-5ef0-4332-9cbf-b16173d9aabe
diff --git a/src/pages/dashboard/components/RouteList.tsx b/src/pages/dashboard/components/RouteList.tsx
@@ -90,7 +90,7 @@ const RouteList: VoidComponent<{ dongleId: string }> = (props) => {
       pages[page] = (async () => {
         const previousPageData = page > 0 ? await getPage(page - 1) : undefined
         const key = getKey(previousPageData)
-        return key ? fetcher<Route[]>(key) : []
+        return key ? fetcher<Route[]>(key).catch(() => []) : []
       })()
     }
     return pages[page]

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ const RouteList: VoidComponent<{ dongleId: string }> = (props) => {`
`90`	`90`	`pages[page] = (async () => {`
`91`	`91`	`const previousPageData = page > 0 ? await getPage(page - 1) : undefined`
`92`	`92`	`const key = getKey(previousPageData)`
`93`		`- return key ? fetcher<Route[]>(key) : []`
	`93`	`+ return key ? fetcher<Route[]>(key).catch(() => []) : []`
`94`	`94`	`})()`
`95`	`95`	`}`
`96`	`96`	`return pages[page]`