revert everything since commaai#578 (commaai#599)

Closes https://github.com/commaai/connect/issues/592

Changes since the PR listed above makes connect loading much less
reliable. @incognitojam I would much rather revert some stuff to put
connect back into a good state than trying to make fixes on top of
things. This is the practice we take at comma across all repos too

could not apply these due to conflicts:
-
commaai/connect@063ca11
-
commaai/connect@a29a97f
-
commaai/connect@b60e915
-
commaai/connect@dde34fa
-
commaai/connect@5485d66
-
commaai/connect@5485d66
-
commaai/connect@bb1f435
-
commaai/connect@77a9bef
-
commaai/connect@8afb206

Author: sshane

src/App.browser.test.tsx

@@ -21,8 +21,8 @@ describe('Demo mode', () => {
   beforeEach(() => setAccessToken(Demo.ACCESS_TOKEN))
 
   test('View dashboard', async () => {
-    const { findAllByText } = renderApp('/')
-    expect(await findAllByText('demo 3X')).toHaveLength(2)
+    const { findByText } = renderApp('/')
+    expect(await findByText('demo 3X')).toBeTruthy()
   })
 
   test('View demo route', async () => {

src/api/athena.ts

@@ -1,4 +1,4 @@
-import type { AthenaCallResponse, BackendAthenaCallResponse, BackendAthenaCallResponseError } from '~/api/types'
+import { AthenaCallResponse, BackendAthenaCallResponse, BackendAthenaCallResponseError } from '~/api/types'
 import { fetcher } from '.'
 import { ATHENA_URL } from './config'
 

src/api/devices.ts

@@ -54,15 +54,6 @@ export const getDevice = async (dongleId: string): Promise<Device> => {
   }
 }
 
-export const updateDevice = async (dongleId: string, data: Partial<Pick<ApiDevice, 'alias'>>) =>
-  fetcher<ApiDevice>(`/v1/devices/${dongleId}/`, {
-    method: 'PATCH',
-    headers: {
-      'Content-Type': 'application/json',
-    },
-    body: JSON.stringify(data),
-  })
-
 export const getAthenaOfflineQueue = (dongleId: string) =>
   fetcher<AthenaOfflineQueueResponse>(`/v1/devices/${dongleId}/athena_offline_queue`)
 
@@ -102,7 +93,7 @@ const validatePairToken = (
 
   try {
     // jwt is base64url encoded
-    const payload = atob(parts[1]!.replace(/-/g, '+').replace(/_/g, '/'))
+    const payload = atob(parts[1].replace(/-/g, '+').replace(/_/g, '/'))
     const { identity, pair } = JSON.parse(payload) as Record<string, unknown>
     if (pair !== true || typeof identity !== 'string') return null
     return { identity, token }

src/api/file.ts

@@ -1,4 +1,4 @@
-import type {
+import {
   CancelUploadRequest,
   CancelUploadResponse,
   Files,
@@ -87,14 +87,13 @@ const generateMissingFilePaths = (
 }
 
 const prepareUploadRequests = (paths: string[], presignedUrls: UploadFileMetadata[]): UploadFile[] =>
-  paths.map((path, i) => ({ filePath: path, ...presignedUrls[i]! }))
+  paths.map((path, i) => ({ filePath: path, ...presignedUrls[i] }))
 
 export const uploadAllSegments = (routeName: string, totalSegments: number, types?: FileType[]) =>
   uploadSegments(routeName, 0, totalSegments - 1, types)
 
 export const uploadSegments = async (routeName: string, segmentStart: number, segmentEnd: number, types?: FileType[]) => {
   const routeInfo = parseRouteName(routeName)
-  if (!routeInfo) return []
   const alreadyUploadedFiles = await getFiles(routeName, types)
   const paths = generateMissingFilePaths(routeInfo, segmentStart, segmentEnd, alreadyUploadedFiles, types)
   const pathPresignedUrls = await requestToUploadFiles(routeInfo.dongleId, paths)

src/api/route.ts

@@ -3,9 +3,8 @@ import type { Route, RouteInfo, RouteShareSignature } from '~/api/types'
 import { fetcher } from '.'
 import { API_URL } from './config'
 
-export const parseRouteName = (routeName: string): RouteInfo | undefined => {
+export const parseRouteName = (routeName: string): RouteInfo => {
   const [dongleId, routeId] = routeName.split('|')
-  if (!dongleId || !routeId) return undefined
   return { dongleId, routeId }
 }
 

src/ci/check_bundle_size.ts

@@ -30,7 +30,7 @@ const totalCompressedSizeKB = (totalCompressedSize / 1024).toFixed(2)
 files.push({}, { path: 'Total', sizeKB: totalSizeKB, compressedSizeKB: totalCompressedSizeKB })
 console.table(files, ['path', 'sizeKB', 'compressedSizeKB'])
 
-const upperBoundKB = 272
+const upperBoundKB = 270
 const lowerBoundKB = upperBoundKB - 10
 if (totalCompressedSize < lowerBoundKB * 1024) {
   console.warn(`Bundle size lower than expected, let's lower the limit! (${totalCompressedSizeKB}KB < ${lowerBoundKB}KB)`)

src/components/DeviceLocation.tsx

@@ -120,7 +120,7 @@ const DeviceLocation: VoidComponent<DeviceLocationProps> = (props) => {
       if (foundLocations.length > 1) {
         args.map.fitBounds(L.latLngBounds(foundLocations.map((l) => [l.lat, l.lng])), { padding: [50, 50] })
       } else if (foundLocations.length === 1) {
-        args.map.setView([foundLocations[0]!.lat, foundLocations[0]!.lng], 15)
+        args.map.setView([foundLocations[0].lat, foundLocations[0].lng], 15)
       } else {
         throw new Error('Offline')
       }

src/components/RouteActions.tsx

@@ -38,8 +38,7 @@ interface RouteActionsProps {
 }
 
 const RouteActions: VoidComponent<RouteActionsProps> = (props) => {
-  const dongleId = () => parseRouteName(props.routeName)?.dongleId
-  const [preservedRoutesResource] = createResource(dongleId, getPreservedRoutes)
+  const [preservedRoutesResource] = createResource(() => parseRouteName(props.routeName).dongleId, getPreservedRoutes)
 
   const [isPublic, setIsPublic] = createSignal<boolean | undefined>(undefined)
   const [isPreserved, setIsPreserved] = createSignal<boolean | undefined>(undefined)

src/components/RouteStaticMap.tsx

@@ -2,8 +2,8 @@ import { createResource, Match, Switch } from 'solid-js'
 import type { JSXElement, VoidComponent } from 'solid-js'
 import clsx from 'clsx'
 
-import { type GPSPathPoint, getCoords } from '~/api/derived'
-import { type Coords, getPathStaticMapUrl } from '~/map'
+import { GPSPathPoint, getCoords } from '~/api/derived'
+import { Coords, getPathStaticMapUrl } from '~/map'
 import { getThemeId } from '~/theme'
 import type { Route } from '~/api/types'
 

src/components/RouteUploadButtons.tsx

@@ -47,6 +47,7 @@ const UploadButton: VoidComponent<UploadButtonProps> = (props) => {
       class="px-2 md:px-3"
       disabled={disabled()}
       leading={<Icon class={clsx(state() === 'loading' && 'animate-spin')} name={stateToIcon[state()]} size="20" />}
+      color="primary"
     >
       <span class="flex items-center gap-1 font-mono">{props.text}</span>
     </Button>