From f5365cb8324a90c2106ee81c0bb418f8a5695c5d Mon Sep 17 00:00:00 2001 From: Jan Lehnardt Date: Thu, 27 Jul 2017 11:39:53 +0200 Subject: [PATCH 1/2] feat: safeguard against invalid data being returned from the webhook --- index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.js b/index.js index 0a5983f..653cf0d 100755 --- a/index.js +++ b/index.js @@ -58,7 +58,7 @@ request({ process.exit(2) } - if (data.ok) { + if (data && data.ok) { return console.log('Announced', packageName + '@' + packageVersion, 'to Greenkeeper') } From 0132030685f9ffc9b0a4de37854d4b81409a77c5 Mon Sep 17 00:00:00 2001 From: Jan Lehnardt Date: Fri, 28 Jul 2017 15:28:08 +0200 Subject: [PATCH 2/2] feat: even better error handling --- index.js | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/index.js b/index.js index 653cf0d..e5a99df 100755 --- a/index.js +++ b/index.js @@ -62,9 +62,14 @@ request({ return console.log('Announced', packageName + '@' + packageVersion, 'to Greenkeeper') } - log.error('postpublish', - res.statusCode + ' ' + - res.statusMessage + - (res.body.message ? ': ' + res.body.message : '') - ) + let errorMessage = '' + if (!res.statusCode || !res.statusMessage) { + errorMessage = JSON.stringify(res) + '\n' + JSON.stringify(data) + } else { + errorMessage = res.statusCode + ' ' + + res.statusMessage + + (res.body.message ? ': ' + res.body.message : '') + } + + log.error('postpublish', errorMessage) })