chore: Improve CI workflows and enhance NFT tests

- Updated contract test workflow to skip unnecessary Node.js dependencies during contract builds.
- Enhanced output logging for compilation warnings in contract tests, saving logs for review.
- Modified NFTGatingEnhanced tests to ensure proper funding of the jar before withdrawals, improving test reliability.
- Adjusted install-deps.sh to skip Foundry installation in CI environments, streamlining the setup process.

These changes enhance the efficiency of CI processes and improve the robustness of NFT-related tests.

Author: Oba-One

.github/workflows/contract-tests.yml

@@ -30,12 +30,14 @@ jobs:
       with:
         version: nightly
 
-    - name: Build contracts (leveraging deploy.sh logic)
+    # Skip all pnpm/Node.js dependencies - contracts tests don't need them
+    
+    - name: Build contracts
       run: |
-        echo "🔧 Building contracts with enhanced validation..."
+        echo "🔧 Building contracts..."
         cd contracts
         
-        # Use forge build with same flags as deploy.sh for consistency
+        # Build contracts with size reporting
         forge build --sizes
         
         if [ $? -ne 0 ]; then
@@ -104,9 +106,14 @@ jobs:
         echo "🔍 Running basic security analysis..."
         cd contracts
         
-        # Check for common issues using forge
         echo "📋 Checking compilation warnings:"
-        forge build 2>&1 | grep -E "(Warning|Error):" || echo "No compilation warnings found"
+        forge build 2>&1 | tee build-warnings.log
+        
+        if grep -E "(Warning|Error):" build-warnings.log; then
+          echo "⚠️  Found compilation warnings/errors"
+        else
+          echo "✅ No compilation warnings found"
+        fi
         
         echo ""
         echo "📋 Contract complexity analysis:"
@@ -128,6 +135,7 @@ jobs:
           contracts/out/
           contracts/lcov.info
           contracts/cache/
+          contracts/build-warnings.log
         retention-days: 7
 
     - name: Test Summary
@@ -145,4 +153,4 @@ jobs:
           echo "❌ Contract tests failed"
           echo "💡 Check output above for details"
           echo "🔧 Fix issues before deployment"
-        fi
+        fi

contracts/test/NFTGatingEnhanced.t.sol

@@ -123,8 +123,14 @@ contract NFTGatingEnhancedTest is Test {
 
     // RESTORED: Basic NFT gating tests - testing currently available functionality
     function test_BasicNFTWithdrawal_ERC721() public {
-        // Ensure jar has sufficient balance and user starts fresh
-        vm.deal(address(jar), 10 ether);
+        // Fund the jar properly using depositETH (this updates currencyHeldByJar)
+        address depositor = address(0x999);
+        vm.deal(depositor, 15 ether); // Give depositor enough ETH including fees
+        
+        vm.prank(depositor);
+        jar.depositETH{value: 10 ether}();
+        
+        // Reset user balance for clean test
         vm.deal(user, 0);
 
         // Mint ERC721 token to user
@@ -154,8 +160,14 @@ contract NFTGatingEnhancedTest is Test {
     }
 
     function test_BasicNFTWithdrawal_ERC1155() public {
-        // Ensure jar has sufficient balance and user starts fresh
-        vm.deal(address(jar), 10 ether);
+        // Fund the jar properly using depositETH (this updates currencyHeldByJar)
+        address depositor = address(0x999);
+        vm.deal(depositor, 15 ether); // Give depositor enough ETH including fees
+        
+        vm.prank(depositor);
+        jar.depositETH{value: 10 ether}();
+        
+        // Reset user balance for clean test
         vm.deal(user, 0);
 
         // Mint ERC1155 tokens to user
@@ -288,8 +300,14 @@ contract NFTGatingEnhancedTest is Test {
     }
 
     function test_GasConsumptionWithinLimits() public {
-        // Ensure jar has sufficient balance and user starts fresh
-        vm.deal(address(jar), 10 ether);
+        // Fund the jar properly using depositETH (this updates currencyHeldByJar)
+        address depositor = address(0x999);
+        vm.deal(depositor, 15 ether); // Give depositor enough ETH including fees
+        
+        vm.prank(depositor);
+        jar.depositETH{value: 10 ether}();
+        
+        // Reset user balance for clean test
         vm.deal(user, 0);
 
         // Mint NFT to user

scripts/install-deps.sh

@@ -64,9 +64,13 @@ else
     echo -e "${GREEN}✅ pnpm v$(get_version pnpm) already installed${NC}"
 fi
 
-# Install Foundry if missing  
+# Install Foundry if missing (skip in CI where official action handles it)
 if ! command_exists forge || ! command_exists anvil; then
-    echo -e "${YELLOW}🔧 Installing Foundry...${NC}"
+    # Skip Foundry installation in CI environments
+    if [ "$CI" = "true" ] || [ "$GITHUB_ACTIONS" = "true" ]; then
+        echo -e "${YELLOW}⏭️  Skipping Foundry installation in CI (handled by official action)${NC}"
+    else
+        echo -e "${YELLOW}🔧 Installing Foundry...${NC}"
 
     # Check if Windows (Git Bash, WSL detection)
     if [[ "$OSTYPE" == "msys" ]] || [[ "$OSTYPE" == "cygwin" ]]; then
@@ -97,13 +101,18 @@ if ! command_exists forge || ! command_exists anvil; then
         echo "   Try running: foundryup"
         echo "   Or visit: https://book.getfoundry.sh/getting-started/installation"
         exit 1
+        fi
+        
+        echo -e "${GREEN}✅ Foundry installed successfully${NC}"
+        echo -e "${YELLOW}💡 You may need to restart your terminal or run: source ~/.bashrc${NC}"
     fi
-    
-    echo -e "${GREEN}✅ Foundry installed successfully${NC}"
-    echo -e "${YELLOW}💡 You may need to restart your terminal or run: source ~/.bashrc${NC}"
 else
     FORGE_VERSION=$(get_version forge)
-    echo -e "${GREEN}✅ Foundry already installed: $FORGE_VERSION${NC}"
+    if [ "$CI" = "true" ] || [ "$GITHUB_ACTIONS" = "true" ]; then
+        echo -e "${GREEN}✅ Foundry available in CI: $FORGE_VERSION${NC}"
+    else
+        echo -e "${GREEN}✅ Foundry already installed: $FORGE_VERSION${NC}"
+    fi
 fi
 
 echo ""