You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(client): stop squishing the GG logomark on the PWA login splash (#564)
## Regression
The PWA login screen logo renders **horizontally squished** — the two
interlocking GG circles are crushed together. Reported during QA: "it
was not like that before."
## Root cause
`public/icon.png` is the wide horizontal GG logomark — **819 × 464
(~1.77:1)**, not a square icon. The PWA design-transition pass
([`d289a9567`](d289a9567))
added `h-24 w-24 sm:h-28 sm:w-28` to the logo `<img>`, forcing the wide
image into a **square box**. Those explicit CSS height+width values
overrode Tailwind preflight's `img { height: auto }` — which had been
preserving the aspect ratio — so the mark got compressed into 96×96 (and
112×112 at `sm`). The asset itself hasn't changed since #87, so this was
purely the CSS regression.
## Fix
- **`Splash.tsx` + `LoadingSplash.tsx`**: constrain height only — `h-24
w-auto sm:h-28` — so width follows the aspect ratio. This matches the
already-correct `SiteHeader` logo (`h-8 w-auto`). Both login-flow
splashes now use the identical treatment, so the login → loading
transition no longer jumps the logo's size or shape.
- Corrected the intrinsic size hint from the misleading square
`width={240} height={240}` to the asset's real `width={819}
height={464}` — a square hint reintroduces the same distortion via the
mapped aspect-ratio before the image loads.
## Verification
- **Brave proof @ 390px** (PWA viewport): rendered ratio **1.765 ==
natural ratio 1.765** (aspect preserved, no distortion); logo renders
169×96. Screenshot shows the round interlocking-circle mark presenting
cleanly.
- Client `Login` tests green (29/29); `bun lint` clean.
Separate from the admin work — small, self-contained client fix off
`develop`.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
0 commit comments