Skip to content

Commit d05864a

Browse files
committed
Assume proprietary/new API keys are flexible
1 parent 2318bd6 commit d05864a

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

Diff for: proxy/protocol/request_key_version.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ func (r *RequestKeyVersion) decode(pd packetDecoder) (err error) {
2424
return err
2525
}
2626

27-
// Determine response header version. Function returns -1 for unknown api key.
27+
// Determine response header version.
28+
// For unknown API keys, return 1 (assume new / proprietary API keys suppoprt flexible versions)
2829
// See also public short responseHeaderVersion(short _version) in kafka/clients/src/generated/java/org/apache/kafka/common/message/ApiMessageType.java
2930
func (r *RequestKeyVersion) ResponseHeaderVersion() int16 {
3031
switch r.ApiKey {
@@ -387,7 +388,7 @@ func (r *RequestKeyVersion) ResponseHeaderVersion() int16 {
387388
case 87: // ReadShareGroupStateSummary
388389
return 1
389390
default:
390-
// throw new UnsupportedVersionException("Unsupported API key " + apiKey);
391-
return -1
391+
// Assume new API keys are always "flexible"
392+
return 1
392393
}
393394
}

0 commit comments

Comments
 (0)