refactor(core): Make SecretsProvider.connect() return Result instead of relying on side effects#1484
Closed
everettbu wants to merge 1 commit into
Closed
Conversation
everettbu
added
core
…of relying on side effects
- Add ConnectResult interface for functional error handling
- SecretsProvider.connect() now returns { success: boolean; error?: Error }
- Remove unused stateHistory tracking and hasEverBeenConnected
- Simplify ProviderLifecycle.connect() to just delegate and log
- Clean up testProviderSettings() method
everettbu
force-pushed
the
ligo-187-tidy-up-internal-connecttest-logic-to-enable-better-error
branch
from
February 6, 2026 14:18
029f802 to
4742691
Compare
Author
|
Upstream PR was closed or merged. Code is synced via branch mirror. |
everettbu
deleted the
ligo-187-tidy-up-internal-connecttest-logic-to-enable-better-error
branch
February 23, 2026 15:57
everettbu
restored the
ligo-187-tidy-up-internal-connecttest-logic-to-enable-better-error
branch
February 23, 2026 16:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of n8n-io/n8n#25433
Original author: geemanjs
Summary
connectreturn a resulttestedlogicPartially done with claude-code
Related Linear tickets, Github issues, and Community forum posts
Closes LIGO-187
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)