fix(editor): Add aria-label to icon-only buttons missing accessible labels#2092
Closed
everettbu wants to merge 5 commits into
Closed
fix(editor): Add aria-label to icon-only buttons missing accessible labels#2092everettbu wants to merge 5 commits into
everettbu wants to merge 5 commits into
Conversation
…abels Icon-only N8nButton/N8nIconButton components trigger a dev warning when they lack aria-label or title. Add appropriate i18n-based aria-labels to all 25 offending instances across 17 files.
Author
|
Upstream PR was closed or merged. Code is synced via branch mirror. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of n8n-io/n8n#26145
Original author: aalises
Summary
Adds
aria-labelattributes to all icon-onlyN8nButtonandN8nIconButtoninstances that were missing accessible labels, eliminating the dev-mode console warning:All labels use i18n — no hardcoded strings. Labels were reviewed for accessibility quality (descriptive action verbs, context-specific where needed).