Revert "Stop outlining unless absolutely necessary"

This reverts commit cec2e82.

Author: eps1lon

packages/react-client/src/ReactFlightClient.js

@@ -3559,8 +3559,18 @@ function resolveErrorDev(
 
   (error: any).name = name;
   (error: any).environmentName = env;
-  if ('cause' in errorInfo) {
-    (error: any).cause = errorInfo.cause;
+  const causeInfo = errorInfo.cause;
+  if (typeof causeInfo === 'string') {
+    // TODO: What bad things can I do by controling the cause reference?
+    const causeReference = causeInfo.slice(1);
+    const cause = getOutlinedModel(
+      response,
+      causeReference,
+      {},
+      '',
+      createModel,
+    );
+    (error: any).cause = cause;
   }
   return error;
 }

packages/react-server/src/ReactFlightServer.js

@@ -4173,7 +4173,9 @@ function serializeErrorValue(request: Request, error: Error): string {
     }
     const errorInfo: ReactErrorInfoDev = {name, message, stack, env};
     if ('cause' in error) {
-      errorInfo.cause = error.cause;
+      const cause: ReactClientValue = (error.cause: any);
+      const causeId = outlineModel(request, cause);
+      errorInfo.cause = serializeByValueID(causeId);
     }
     const id = outlineModel(request, errorInfo);
     return '$Z' + id.toString(16);
@@ -4185,7 +4187,11 @@ function serializeErrorValue(request: Request, error: Error): string {
   }
 }
 
-function serializeDebugErrorValue(request: Request, error: Error): string {
+function serializeDebugErrorValue(
+  request: Request,
+  counter: {objectLimit: number},
+  error: Error,
+): string {
   if (__DEV__) {
     let name: string = 'Error';
     let message: string;
@@ -4208,7 +4214,10 @@ function serializeDebugErrorValue(request: Request, error: Error): string {
     }
     const errorInfo: ReactErrorInfoDev = {name, message, stack, env};
     if ('cause' in error) {
-      errorInfo.cause = error.cause;
+      counter.objectLimit--;
+      const cause: ReactClientValue = (error.cause: any);
+      const causeId = outlineDebugModel(request, counter, cause);
+      errorInfo.cause = serializeByValueID(causeId);
     }
     const id = outlineDebugModel(
       request,
@@ -4252,10 +4261,7 @@ function emitErrorChunk(
           env = errorEnv;
         }
         if ('cause' in error) {
-          // We're stringifying the error info without a replacer so we need to
-          // make sure the Flight Client can revive the cause.
-          // TODO: outline model accepts a serializeable value instead of a ready Client value
-          const cause: ReactClientValue = (error.cause: $FlowFixMe);
+          const cause: ReactClientValue = (error.cause: any);
           const causeId = debug
             ? outlineDebugModel(request, {objectLimit: 5}, cause)
             : outlineModel(request, cause);
@@ -4990,7 +4996,7 @@ function renderDebugModel(
       return serializeDebugFormData(request, value);
     }
     if (value instanceof Error) {
-      return serializeDebugErrorValue(request, value);
+      return serializeDebugErrorValue(request, counter, value);
     }
     if (value instanceof ArrayBuffer) {
       return serializeDebugTypedArray(request, 'A', new Uint8Array(value));