Skip to content

Commit 6a21fdf

Browse files
fix errors
1 parent 604e7d0 commit 6a21fdf

File tree

7 files changed

+37
-155
lines changed

7 files changed

+37
-155
lines changed

jest.setup.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
66
*/
77

8-
import { TextEncoder, TextDecoder } from 'util';
8+
import { TextEncoder, TextDecoder } from 'node:util';
99

1010
// fix for ReferenceError: TextDecoder / TextEncoder is not defined
1111
Object.assign(global, { TextDecoder, TextEncoder });

src/components/App/app-wrapper.tsx

+1-2
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,12 @@ import {
3030
top_bar_en,
3131
top_bar_fr,
3232
} from '@gridsuite/commons-ui';
33-
import { IntlProvider } from 'react-intl';
33+
import { IntlConfig, IntlProvider } from 'react-intl';
3434
import { Provider, useSelector } from 'react-redux';
3535
import messages_en from '../../translations/en.json';
3636
import messages_fr from '../../translations/fr.json';
3737
import { store } from '../../redux/store';
3838
import { PARAM_THEME } from '../../utils/config-params';
39-
import { IntlConfig } from 'react-intl/src/types';
4039
import { AppState } from '../../redux/reducer';
4140
import { AppWithAuthRouter } from '../../routes';
4241

src/pages/profiles/modification/custom-mui-dialog.tsx

-120
This file was deleted.

src/pages/profiles/modification/parameter-selection.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { Grid, IconButton, Tooltip } from '@mui/material';
1212
import { useIntl } from 'react-intl';
1313
import { DirectoryItemSelector, ElementType } from '@gridsuite/commons-ui';
1414
import { useController, useWatch } from 'react-hook-form';
15-
import { fetchPath } from 'services/directory';
15+
import { DirectorySrv } from '../../../services';
1616
import LinkedPathDisplay from './linked-path-display';
1717

1818
export interface ParameterSelectionProps {
@@ -45,7 +45,7 @@ const ParameterSelection: FunctionComponent<ParameterSelectionProps> = (
4545
setSelectedElementName(undefined);
4646
setParameterLinkValid(undefined);
4747
} else {
48-
fetchPath(watchParamId)
48+
DirectorySrv.fetchPath(watchParamId)
4949
.then((res: any) => {
5050
setParameterLinkValid(true);
5151
setSelectedElementName(

src/pages/profiles/modification/profile-modification-dialog.tsx

+18-14
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import ProfileModificationForm, {
1010
PROFILE_NAME,
1111
USER_QUOTAS,
1212
} from './profile-modification-form';
13-
import yup from 'utils/yup-config';
13+
import yup from '../../../utils/yup-config';
1414
import { yupResolver } from '@hookform/resolvers/yup';
1515
import { useForm } from 'react-hook-form';
1616
import {
@@ -20,18 +20,17 @@ import {
2020
useMemo,
2121
useState,
2222
} from 'react';
23-
import { useSnackMessage } from '@gridsuite/commons-ui';
24-
import { getProfile, modifyProfile, UserProfile } from 'services/user-admin';
25-
import CustomMuiDialog from './custom-mui-dialog';
23+
import { CustomMuiDialog, useSnackMessage } from '@gridsuite/commons-ui';
24+
import { UserAdminSrv, UserProfile } from '../../../services';
2625
import { UUID } from 'crypto';
2726

28-
// TODO remove FetchStatus when available in commons-ui (available soon)
29-
export const FetchStatus = {
30-
IDLE: 'IDLE',
31-
FETCHING: 'FETCHING',
32-
FETCH_SUCCESS: 'FETCH_SUCCESS',
33-
FETCH_ERROR: 'FETCH_ERROR',
34-
};
27+
// TODO remove FetchStatus when exported in commons-ui (available soon)
28+
export enum FetchStatus {
29+
IDLE = 'IDLE',
30+
FETCHING = 'FETCHING',
31+
FETCH_SUCCESS = 'FETCH_SUCCESS',
32+
FETCH_ERROR = 'FETCH_ERROR',
33+
}
3534

3635
export interface ProfileModificationDialogProps {
3736
profileId: UUID | undefined;
@@ -44,7 +43,9 @@ const ProfileModificationDialog: FunctionComponent<
4443
ProfileModificationDialogProps
4544
> = ({ profileId, open, onClose, onUpdate }) => {
4645
const { snackError } = useSnackMessage();
47-
const [dataFetchStatus, setDataFetchStatus] = useState(FetchStatus.IDLE);
46+
const [dataFetchStatus, setDataFetchStatus] = useState<FetchStatus>(
47+
FetchStatus.IDLE
48+
);
4849

4950
const formSchema = yup
5051
.object()
@@ -57,6 +58,7 @@ const ProfileModificationDialog: FunctionComponent<
5758
.nullable(),
5859
})
5960
.required();
61+
console.log('formSchema =', formSchema);
6062

6163
const formMethods = useForm({
6264
resolver: yupResolver(formSchema),
@@ -73,7 +75,8 @@ const ProfileModificationDialog: FunctionComponent<
7375
loadFlowParameterId: profileFormData[LF_PARAM_ID],
7476
maxAllowedCases: profileFormData[USER_QUOTAS],
7577
};
76-
modifyProfile(profileData)
78+
console.log('modify', profileData);
79+
UserAdminSrv.modifyProfile(profileData)
7780
.catch((error) => {
7881
snackError({
7982
messageTxt: error.message,
@@ -96,9 +99,10 @@ const ProfileModificationDialog: FunctionComponent<
9699
useEffect(() => {
97100
if (profileId && open) {
98101
setDataFetchStatus(FetchStatus.FETCHING);
99-
getProfile(profileId)
102+
UserAdminSrv.getProfile(profileId)
100103
.then((response) => {
101104
setDataFetchStatus(FetchStatus.FETCH_SUCCESS);
105+
console.log('reset', response);
102106
reset({
103107
[PROFILE_NAME]: response.name,
104108
[LF_PARAM_ID]: response.loadFlowParameterId

src/services/apps-metadata.ts

+12-1
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,21 @@
55
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
66
*/
77

8-
import { Env, IdpSettings } from '@gridsuite/commons-ui';
8+
import { Env } from '@gridsuite/commons-ui';
99
import { getErrorMessage } from '../utils/error';
1010
import { Url } from '../utils/api-rest';
1111

12+
// TODO remove when exported in commons-ui (src/utils/AuthService.ts)
13+
type IdpSettings = {
14+
authority: string;
15+
client_id: string;
16+
redirect_uri: string;
17+
post_logout_redirect_uri: string;
18+
silent_redirect_uri: string;
19+
scope: string;
20+
maxExpiresIn?: number;
21+
};
22+
1223
export type EnvJson = Env & typeof import('../../public/env.json');
1324

1425
function fetchEnv(): Promise<EnvJson> {

src/services/index.ts

+3-15
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,3 @@
1-
import * as Config from './config';
2-
import * as ConfigNotif from './config-notification';
3-
import * as AppsMetadata from './apps-metadata';
4-
import * as Study from './study';
5-
import * as UserAdmin from './user-admin';
6-
7-
const _ = {
8-
...Config,
9-
...ConfigNotif,
10-
...AppsMetadata,
11-
...Study,
12-
...UserAdmin,
13-
};
14-
export default _;
15-
161
export * as ConfigSrv from './config';
172
export type * from './config';
183

@@ -27,3 +12,6 @@ export type * from './study';
2712

2813
export * as UserAdminSrv from './user-admin';
2914
export type * from './user-admin';
15+
16+
export * as DirectorySrv from './directory';
17+
export type * from './directory';

0 commit comments

Comments
 (0)