Enable unused variables detection and fix ESLint violations

Signed-off-by: achour94 <[email protected]>

Author: achour94

eslint.config.js

@@ -181,7 +181,6 @@ const projectConfig = [
             '@typescript-eslint/consistent-type-definitions': 'off',
             '@typescript-eslint/no-empty-object-type': 'off',
             '@typescript-eslint/no-shadow': 'off',
-            '@typescript-eslint/no-unused-vars': 'off',
             '@typescript-eslint/no-use-before-define': 'off',
             '@typescript-eslint/no-unsafe-function-type': 'off',
 

src/pages/common/paper-form.tsx

@@ -12,7 +12,7 @@ import { Paper, PaperProps } from '@mui/material';
  * <Paper> is defined in <Dialog> without generics, which default to `PaperProps => PaperProps<'div'>`,
  *   so we must trick typescript check with a cast
  */
-const PaperForm: FunctionComponent<PaperProps<'form'> & { untypedProps?: PaperProps }> = (props, context) => {
+const PaperForm: FunctionComponent<PaperProps<'form'> & { untypedProps?: PaperProps }> = (props, _context) => {
     const { untypedProps, ...formProps } = props;
     const othersProps = untypedProps as PaperProps<'form'>; //trust me ts
     return <Paper component="form" {...formProps} {...(othersProps ?? {})} />;

src/pages/groups/add-group-dialog.tsx

@@ -36,7 +36,7 @@ const AddGroupDialog: FunctionComponent<AddGroupDialogProps> = (props) => {
     const addGroup = useCallback(
         (group: string) => {
             UserAdminSrv.addGroup(group)
-                .catch((error) =>
+                .catch((_error) =>
                     snackError({
                         headerId: 'groups.table.error.add',
                         headerValues: {
@@ -85,7 +85,7 @@ const AddGroupDialog: FunctionComponent<AddGroupDialogProps> = (props) => {
                     name="group"
                     control={control}
                     rules={{ required: true, minLength: 1 }}
-                    render={({ field, fieldState, formState }) => (
+                    render={({ field, fieldState }) => (
                         <TextField
                             {...field}
                             autoFocus

src/pages/profiles/add-profile-dialog.tsx

@@ -45,7 +45,7 @@ const AddProfileDialog: FunctionComponent<AddProfileDialogProps> = (props) => {
                 name: name,
             };
             UserAdminSrv.addProfile(profileData)
-                .catch((error) =>
+                .catch((_error) =>
                     snackError({
                         headerId: 'profiles.table.error.add',
                         headerValues: {
@@ -89,7 +89,7 @@ const AddProfileDialog: FunctionComponent<AddProfileDialogProps> = (props) => {
                     name="name"
                     control={control}
                     rules={{ required: true, minLength: 1 }}
-                    render={({ field, fieldState, formState }) => (
+                    render={({ field, fieldState }) => (
                         <TextField
                             {...field}
                             autoFocus

src/pages/users/add-user-dialog.tsx

@@ -42,7 +42,7 @@ const AddUserDialog: FunctionComponent<AddUserDialogProps> = (props) => {
     const addUser = useCallback(
         (id: string) => {
             UserAdminSrv.addUser(id)
-                .catch((error) =>
+                .catch((_error) =>
                     snackError({
                         headerId: 'users.table.error.add',
                         headerValues: {
@@ -86,7 +86,7 @@ const AddUserDialog: FunctionComponent<AddUserDialogProps> = (props) => {
                     name="name"
                     control={control}
                     rules={{ required: true, minLength: 1 }}
-                    render={({ field, fieldState, formState }) => (
+                    render={({ field, fieldState }) => (
                         <TextField
                             {...field}
                             autoFocus

src/redux/reducer.ts

@@ -121,7 +121,7 @@ export const reducer = createReducer<AppState>(initialState, (builder) => {
         state.authenticationRouterError = action.authenticationRouterError;
     });
 
-    builder.addCase(RESET_AUTHENTICATION_ROUTER_ERROR, (state, action: AuthenticationRouterErrorAction) => {
+    builder.addCase(RESET_AUTHENTICATION_ROUTER_ERROR, (state, _action: AuthenticationRouterErrorAction) => {
         state.authenticationRouterError = null;
     });
 

src/utils/api.ts

@@ -34,7 +34,7 @@ export function extractUserSub(user: User | null): Promise<unknown> {
 export function parseError(text: string) {
     try {
         return JSON.parse(text);
-    } catch (err) {
+    } catch {
         return null;
     }
 }

src/utils/hooks.ts

@@ -8,7 +8,7 @@
 import { FilterChangedEvent, GridApi, IRowNode, SelectionChangedEvent } from 'ag-grid-community';
 import { useCallback, useState } from 'react';
 
-export function useDebugRender(label: string) {
+export function useDebugRender(_label: string) {
     // uncomment when you want the output in the console
     /*if (import.meta.env.DEV) {
         label = `${label} render`;