Skip to content

Commit 911d116

Browse files
authored
Merge branch 'main' into fix/17/dismiss-dialog-autoclose
2 parents 6e143fc + 26d62d5 commit 911d116

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

grimmory.koplugin/grimmory/ui/dialog_manager.lua

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -360,12 +360,16 @@ function DialogManager:showPluginUpdater()
360360
end)
361361
end
362362

363-
function DialogManager:showProgressDialog(title, dismiss_callback)
363+
function DialogManager:showProgressDialog(title, dismiss_callback, dismiss_text)
364364
local dialog
365365
local confirm_dialog
366366
local is_closing = false
367367

368368
if dismiss_callback ~= nil then
369+
if dismiss_text == nil then
370+
dismiss_text = _("Terminate this task?")
371+
end
372+
369373
dismiss_callback = function()
370374
if is_closing then
371375
-- The dismiss callback is fired even when
@@ -379,7 +383,7 @@ function DialogManager:showProgressDialog(title, dismiss_callback)
379383
end
380384

381385
confirm_dialog = ConfirmBox:new({
382-
text = _("Cancel Synchronization?"),
386+
text = dismiss_text,
383387
ok_callback = function()
384388
pcall(dismiss_callback)
385389
UIManager:close(dialog)

grimmory.koplugin/main.lua

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,8 @@ function Grimmory:onGrimmorySync(verbose)
331331
_("Synchronizing to Grimmory"),
332332
function()
333333
should_terminate = true
334-
end
334+
end,
335+
_("Are you sure you want to interrupt synchronization?")
335336
)
336337
end
337338

0 commit comments

Comments
 (0)