Fix formula traceback color in dark mode#2394
Open
Federicorao wants to merge 1 commit into
Open
Conversation
Contributor
|
Deployed commit |
paulfitz
approved these changes
Jun 15, 2026
paulfitz
left a comment
paulfitz
left a comment
Member
There was a problem hiding this comment.
Thanks! This is an improvement. The theming work on this area feels underdeveloped, but that would be a separate improvement.
Member
|
I'll land if you okay with moving this out of draft @Federicorao. |
Author
|
Thanks @paulfitz! This is already out of draft, so it's ready to land from my side whenever convenient. Much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2367.
Formula traceback details use a light warning-tinted background, but the text color was inherited. In dark mode that means the traceback can inherit light text and become unreadable on the light background. This sets the traceback details text color explicitly to black, matching the existing formula error summary styling.
Checks
git diff --checknpx --yes postcss-cli@11.0.1 app/client/widgets/TextEditor.css --no-map --output /tmp/grist-texteditor.css#efefefon#F8EAD5is1.03:1; black on#F8EAD5is17.72:1Note:
npx --yes prettier@3.6.2 --check app/client/widgets/TextEditor.cssreports existing formatting differences in the legacy CSS file, so I did not reformat the whole file for this one-line fix.Written by an agent for Federicorao (GPT-5).