Skip to content

Conflict with Model Names & Different Model Identifiers #23

@smatthews0

Description

@smatthews0

I've noticed an issue where Model Names can cause conflicts where the Model Identifier differ and was failing the script out.

Model:MacBook Pro (16-inch, 2023)
Model Identifier:Mac14,10
M2 Pro

Model:MacBook Pro (16-inch, 2023)
Model Identifier:Mac14,6
M2 Max

I was getting the failure
2024-09-23 16:51:44 - INFO - Processing entry 3 out of 151 - Device Name: *** - Device ID: ****
2024-09-23 16:51:44 - INFO - Could not find a model ID in Snipe-IT for: MacBook Pro (16-inch, 2023)
Traceback (most recent call last):
File "", line 790, in
create_snipe_model(newmodel)
File "
", line 558, in create_snipe_model
modelnumbers[jsonresponse['payload']['model_number']] = jsonresponse['payload']['id']
~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
TypeError: 'NoneType' object is not subscriptable

Adding a new Model with the Model Identifier bypassed the error

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

Status

Ready

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions