Merge pull request #14711 from snipe/jerm/fix-all-query-in-sidebar-middleware

snipe · web-flow · commit 2decc3d6d3fe · 2024-05-11T01:35:09.000+01:00
Fix memory-hog query in AssetCountForSidebar middleware
diff --git a/app/Http/Middleware/AssetCountForSidebar.php b/app/Http/Middleware/AssetCountForSidebar.php
@@ -35,7 +35,7 @@ public function handle($request, Closure $next)
         }
 
         try {
-            $total_assets = Asset::all()->count();
+            $total_assets = Asset::count();
             if ($settings->show_archived_in_list != '1') {
                 $total_assets -= Asset::Archived()->count();
             }

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public function handle($request, Closure $next)`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`try {`
`38`		`- $total_assets = Asset::all()->count();`
	`38`	`+ $total_assets = Asset::count();`
`39`	`39`	`if ($settings->show_archived_in_list != '1') {`
`40`	`40`	`$total_assets -= Asset::Archived()->count();`
`41`	`41`	`}`