Merge pull request #16361 from Godmartinz/acceptancer_reminder_unlisted_email_info

Fixed acceptance reminder command lag on users with no associated email

Author: snipe

app/Console/Commands/SendAcceptanceReminder.php

@@ -64,6 +64,7 @@ public function handle()
             ->groupBy(function($item) {
                 return $item['acceptance']->assignedTo ? $item['acceptance']->assignedTo->id : '';
             });
+            $no_email_list= [];
 
         foreach($unacceptedAssetGroups as $unacceptedAssetGroup) {
             // The [0] is weird, but it allows for the item_count to work and grabs the appropriate info for each user.
@@ -72,7 +73,10 @@ public function handle()
             $locale = $acceptance->assignedTo?->locale;
             $email = $acceptance->assignedTo?->email;
             if(!$email){
-                $this->info($acceptance->assignedTo?->present()->fullName().' has no email address.');
+                $no_email_list[] = [
+                    'id' => $acceptance->assignedTo->id,
+                    'name' => $acceptance->assignedTo->present()->fullName(),
+                ];
             }
             $item_count = $unacceptedAssetGroup->count();
 
@@ -86,6 +90,14 @@ public function handle()
         }
 
         $this->info($count.' users notified.');
+        $headers = ['ID', 'Name'];
+        $rows = [];
+
+        foreach ($no_email_list as $user) {
+            $rows[] = [$user['id'], $user['name']];
+        }
+        $this->info("The following users do not have an email address:");
+        $this->table($headers, $rows);
 
         return 0;
     }

tests/Feature/Console/SendAcceptanceReminderTest.php

@@ -43,9 +43,13 @@ public function testAcceptanceReminderCommandHandlesUserWithoutEmail()
         CheckoutAcceptance::factory()->pending()->create([
             'assigned_to_id' => $userA->id,
         ]);
-
+        $headers = ['ID', 'Name'];
+        $rows = [
+            [$userA->id, $userA->present()->fullName()],
+        ];
         $this->artisan('snipeit:acceptance-reminder')
-            ->expectsOutput($userA->present()->fullName().' has no email address.')
+            ->expectsOutput("The following users do not have an email address:")
+            ->expectsTable($headers, $rows)
             ->assertExitCode(0);
 
         Mail::assertNotSent(UnacceptedAssetReminderMail::class);