Merge pull request #120 from imbus/Sit-202-use-logging-and-avoid-duplications

Sit 202 use logging and avoid duplications

Author: JonasGoseberg

app/Console/Commands/Purge.php

@@ -180,11 +180,11 @@ public function handle()
                 $status_label->forceDelete();
             }
 
-            $predefined_filters = PredefinedFilter::whereNotNull('deleted_at')->withTrashed()->get();
-            $this->info($predefined_filters->count().' predefined filters purged.');
-            foreach ($predefined_filters as $predefined_filter) {
-                $this->info('- Predefined Filter "'.$predefined_filter->name.'" deleted.');
-                $predefined_filter->forceDelete();
+            $predefinedFilters = PredefinedFilter::whereNotNull('deleted_at')->withTrashed()->get();
+            $this->info($predefinedFilters->count().' predefined filters purged.');
+            foreach ($predefinedFilters as $predefinedFilter) {
+                $this->info('- Predefined Filter "'.$predefinedFilter->name.'" deleted.');
+                $predefinedFilter->forceDelete();
             }
 
         } else {

app/Services/PredefinedFilterPermissionService.php

@@ -5,6 +5,7 @@
 use Exception;
 use App\Models\PredefinedFilterPermission;
 use Illuminate\Support\Facades\Auth;
+use Log;
 
 class PredefinedFilterPermissionService
 {
@@ -17,7 +18,7 @@ public function store(array $validated): PredefinedFilterPermission
         $permission->permission_group_id = $validated['permission_group_id'];
         $permission->created_by = $userId;
         if (!$permission->save()) {
-            throw new Exception($permission->getErrors());
+            Log::error($permission->getErrors());
         }
 
         return $permission;

database/seeders/PredefinedFilterPermissionSeeder.php

@@ -10,6 +10,7 @@
 use App\Models\User;
 use Illuminate\Contracts\Auth\Guard;
 use Illuminate\Support\Facades\Hash;
+use Log;
 
 class PredefinedFilterPermissionSeeder extends Seeder
 {
@@ -53,8 +54,7 @@ public function run(): void
                 ]);
             }
         }catch (\Exception $e) {
-            echo "Error: " . $e->getMessage() . "\n";
-            echo $e->getTraceAsString();
+            Log::debug($e);
         }
     }
 }

tests/TestCase.php

@@ -5,6 +5,7 @@
 use App\Http\Middleware\SecurityHeaders;
 use Illuminate\Foundation\Testing\LazilyRefreshDatabase;
 use Illuminate\Foundation\Testing\TestCase as BaseTestCase;
+use Log;
 use RuntimeException;
 use Tests\Support\AssertsAgainstSlackNotifications;
 use Tests\Support\AssertHasActionLogs;
@@ -52,7 +53,7 @@ protected function setUp(): void
             \DB::statement("SET time_zone = '+00:00'");
 
         } catch (\Throwable $e) {
-            
+            Log::debug($e);
         }
     }