Merge pull request #17611 from grokability/#9965-fallback-to-category-image-for-consumables

Fixed #9965 - fallback to category images (f there are any) when no c…

Author: snipe

app/Http/Transformers/ConsumablesTransformer.php

@@ -25,7 +25,7 @@ public function transformConsumable(Consumable $consumable)
         $array = [
             'id'            => (int) $consumable->id,
             'name'          => e($consumable->name),
-            'image' =>   ($consumable->image) ? Storage::disk('public')->url('consumables/'.e($consumable->image)) : null,
+            'image' =>   ($consumable->getImageUrl()) ? ($consumable->getImageUrl()) : null,
             'category'      => ($consumable->category) ? ['id' => $consumable->category->id, 'name' => e($consumable->category->name)] : null,
             'company'   => ($consumable->company) ? ['id' => (int) $consumable->company->id, 'name' => e($consumable->company->name)] : null,
             'item_no'       => e($consumable->item_no),

app/Models/Consumable.php

@@ -230,11 +230,16 @@ public function assetlog()
      */
     public function getImageUrl()
     {
+        // If there is a consumable image, use that
         if ($this->image) {
             return Storage::disk('public')->url(app('consumables_upload_path').$this->image);
+
+        // Otherwise check for a category image
+        }   elseif (($this->category) && ($this->category->image)) {
+            return Storage::disk('public')->url(app('categories_upload_path').e($this->category->image));
         }
-        return false;
 
+        return false;
     }
 
     /**