Merge pull request #117 from imbus/SIT-202-avoidUsingUndefinedVariables

fixed using undefined variable and removed some old stuff

Author: JonasGoseberg

app/Http/Transformers/PredefinedFiltersTransformer.php

@@ -56,9 +56,11 @@ public function transformPredefinedFilter($filter)
             $array['groups'] = null;
         }
 
+        $permissionsArray = [];
+
         $permissionsArray['available_actions'] = [
-            'update' => $filter->created_by === auth()->id() || $filter->userHasPermission(auth()->user(), 'edit'),
-            'delete' => $filter->created_by === auth()->id() || $filter->userHasPermission(auth()->user(), 'delete')
+            'update' => $filter->userHasPermission(auth()->user(), 'edit'),
+            'delete' => $filter->userHasPermission(auth()->user(), 'delete')
         ];
         return $array += $permissionsArray;
     }

tests/Feature/PredefinedFilter/Api/PredefinedFilterControllerTest.php

@@ -737,7 +737,7 @@ public function test_transform_without_permission_groups_loaded_sets_groups_null
         $this->assertFalse($result['available_actions']['delete']);
     }
 
-    public function test_transform_sets_available_actions_true_for_owner()
+    public function test_transform_sets_available_actions_false_for_owner()
     {
         $this->transformer = new PredefinedFiltersTransformer();
 
@@ -754,8 +754,8 @@ public function test_transform_sets_available_actions_true_for_owner()
 
         $result = $this->transformer->transformPredefinedFilter($filter);
 
-        $this->assertTrue($result['available_actions']['update']);
-        $this->assertTrue($result['available_actions']['delete']);
+        $this->assertFalse($result['available_actions']['update']);
+        $this->assertFalse($result['available_actions']['delete']);
     }
 
     public function test_transform_formats_dates_correctly()